Handle asset gems in a sane manner #2028
Conversation
|
Not sure where Rails 3.0 was getting its dose of CoffeeScript before this PR... |
|
I'm going to set this for the 0.6.0 release. Really don't feel like figuring out a hack for Rails 3.0. |
|
What's the status of this issue given that the 0.6.0 release is out? |
|
Given that 0.6.0 became what 0.5.2 would have been, had the release not been so far delayed, this PR has been pushed into 0.7.0. If someone can figure out a way to get this working with Rails 3.0, we can include it in 0.6.1 instead. |
|
What's the problem with this issue and Rails 3.0? |
|
Look at the Travis test build. |
|
(I don't really know what the problem is) |
|
coffee-rails isn't available for Rails < 3.1.0. There seems to be two obvious solutions:
|
|
But there must be some other version of CoffeeScript available. I mean, our test suite never failed before this. |
|
It could be that a dependency was yanked from RubyGems, I'd have to investigate to find out for certain. It seems that the coffeescript-rails repo has only ever supported Rails 3.1.0 and greater. Quickly Googling about, Barista seems to be the way to get Rails of many versions using CoffeeScript. |
|
It's somehow already included, hence why everything on master works with Rails 3.0. But I don't know what is adding it in, so I don't know how to ensure that it's loaded. |
Instead of having hard requirements for asset-related gems in our gemspec, this approach allows us to require them as needed. + use Bundler to confirm that asset gems are installed + remove asset compilation code that's no longer needed
+ changed the JS template file to use CoffeeScript + added a few tests to ensure core AA files are created by the generator
|
This implementation is out of date. I wrote a better one that currently resides on the rails4 branch. |
This allows us to conditionally require asset-related gems instead of hardcoding them into the gemspec.
Related issues: #437, #1259, #1686