-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for .svgrrc #86
Comments
@neoziro cool, thanks for pulling the issues together. Is anyone currently on track to do this? I might be able to take a stab at this sometime this week. Also super stoked to see svgr in create-react-app! |
Yeah I am very happy that it is now in create-react-app. Next week I am going to talk about it at React Europe. About the issue, you can take it if you want :) |
@neoziro that's awesome, you should definitely have a slide saying, now that you've seen all this awesomeness, and you're not sure how to set it up, don't worry, because create-react-app 2.0 will have it included. I think that will encourage a lot of people and get some excitement around it for the less technical users. |
Yes you are right! |
@neoziro should I work out of the master branch? |
@lifeiscontent no on next branch |
@neoziro sorry for the slow replies, it seems the snapshot tests are out of date, should I update them with |
Yes update them if they are not OK. |
@neoziro should we close this? I forgot to add it to the commit message. |
No I close it when I release the new version. |
v2 is published 🎉 |
Nice! |
As mentioned in #81 by @lifeiscontent, SVGR should have its own
.svgrrc
in order to be able to specify desired options.I like the way Prettier is doing it:
resolveConfig
,resolveConfigFile
andclearConfigCache
cosmiconfig is the good candidate to do it.
To resume :
.svgrrc
and other default from cosmiconfigresolveConfig
,resolveConfigFile
andclearConfigCache
The text was updated successfully, but these errors were encountered: