Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .svgrrc #86

Closed
2 tasks done
gregberge opened this issue May 12, 2018 · 12 comments
Closed
2 tasks done

Add support for .svgrrc #86

gregberge opened this issue May 12, 2018 · 12 comments
Milestone

Comments

@gregberge
Copy link
Owner

gregberge commented May 12, 2018

As mentioned in #81 by @lifeiscontent, SVGR should have its own .svgrrc in order to be able to specify desired options.

I like the way Prettier is doing it:

cosmiconfig is the good candidate to do it.

To resume :

  • Load configuration from .svgrrc and other default from cosmiconfig
  • Expose resolveConfig, resolveConfigFile and clearConfigCache
@gregberge gregberge added this to the v2 milestone May 12, 2018
@lifeiscontent
Copy link
Contributor

@neoziro cool, thanks for pulling the issues together. Is anyone currently on track to do this? I might be able to take a stab at this sometime this week. Also super stoked to see svgr in create-react-app!

@gregberge
Copy link
Owner Author

Yeah I am very happy that it is now in create-react-app. Next week I am going to talk about it at React Europe.

About the issue, you can take it if you want :)

@gregberge gregberge mentioned this issue May 12, 2018
8 tasks
@lifeiscontent
Copy link
Contributor

@neoziro that's awesome, you should definitely have a slide saying, now that you've seen all this awesomeness, and you're not sure how to set it up, don't worry, because create-react-app 2.0 will have it included.

I think that will encourage a lot of people and get some excitement around it for the less technical users.

@gregberge
Copy link
Owner Author

Yes you are right!

@lifeiscontent
Copy link
Contributor

@neoziro should I work out of the master branch?

@gregberge
Copy link
Owner Author

@lifeiscontent no on next branch

@lifeiscontent
Copy link
Contributor

@neoziro sorry for the slow replies, it seems the snapshot tests are out of date, should I update them with -u or are they just not passing on next?

@gregberge
Copy link
Owner Author

Yes update them if they are not OK.

@lifeiscontent
Copy link
Contributor

@neoziro should we close this? I forgot to add it to the commit message.

@gregberge
Copy link
Owner Author

No I close it when I release the new version.

@gregberge
Copy link
Owner Author

v2 is published 🎉

@lifeiscontent
Copy link
Contributor

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants