Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BatchReplyConsumer should use shared ThreadPool #13

Open
gregbugaj opened this issue Feb 22, 2021 · 1 comment
Open

BatchReplyConsumer should use shared ThreadPool #13

gregbugaj opened this issue Feb 22, 2021 · 1 comment
Assignees
@gregbugaj
Labels
enhancement New feature or request
Milestone
1.1.6 Release

Comments

@gregbugaj
Copy link
Owner

Following constructor should not be using Fixed thread pool but rather a shared one.

public BatchReplyConsumer(final Channel channel,
                              final ConcurrentHashMap<UUID, CompletableFutureWrapperBatchContext> batches) {
        this(channel, batches,
                Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors()));
    }
@gregbugaj gregbugaj added the enhancement New feature or request label Feb 22, 2021
@gregbugaj gregbugaj added this to the 1.1.6 Release milestone Feb 22, 2021
@gregbugaj gregbugaj self-assigned this Feb 22, 2021
@create-issue-branch
Copy link

Branch issue-13-BatchReplyConsumer_should_use_shared_ThreadPool created!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregbugaj gregbugaj

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1.6 Release
Development

No branches or pull requests
1 participant
@gregbugaj