Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running cljfmt with all rules disabled still produces diffs #9

Closed
drewinglis opened this issue Aug 2, 2019 · 3 comments
Closed

Running cljfmt with all rules disabled still produces diffs #9

drewinglis opened this issue Aug 2, 2019 · 3 comments

Comments

@drewinglis
Copy link
Contributor

drewinglis commented Aug 2, 2019

The most notable diff is that for named functions it doesn't allow the arguments list to stay on the same line:

$ cljfmt check foo.clj 
--- a/foo.clj
+++ b/foo.clj
@@ -1,2 +1,3 @@
-(fn foo [arg-one]
+(fn foo
+[arg-one]
   nil)
1 files formatted incorrectly
$ cat foo.clj 
(fn foo [arg-one]
  nil)
@greglook
Copy link
Owner

greglook commented Aug 5, 2019

:line-break-functions? controls this behavior and wasn't disabled by your config. It was also missing from the README. Added in 7c5d943.

@greglook
Copy link
Owner

greglook commented Aug 6, 2019

I wonder if it's worth adding a --no-defaults option to the CLI to better support this sort of isolation. 🤔

@drewinglis
Copy link
Contributor Author

I'm fine with closing this out with the resolution being "fixed docs". I think as long as you give the user a way to run it with everything turned off then that's fine. I don't think a special option is needed, though I would probably still use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants