Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update about_asserts.py #119

Closed
wants to merge 1 commit into from

Conversation

codeNameMahi
Copy link

added assertIn test

added assertIn test
@dstanek
Copy link
Collaborator

dstanek commented Jan 2, 2016

Instead of doing this and making a test for assertIn I think it would be better to either:

  1. work assertIn into another part of a lesson to test something else (there is not explicit assertEqual just to test assertEqual)
  2. create a lesson specifically for doing unittest stuff

@gregmalcolm
Copy link
Owner

Thanks for the PR!

Yeah, probably don't want to drag out about_asserts too much. Students are usually hungry to get with something more interesting at that stage in the koans. I like @dstanek's suggestion of rolling it into a later koan. Maybe find an existing koan that could use this kind of assert and modify that.

Also if you're up for the challenge, can you provide a Python3 flavor as well please?

Closing for now, but feel free to open another PR if you want to take this forwards

@gregmalcolm gregmalcolm closed this Jan 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants