Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single grid column for single filter #613

Merged
merged 1 commit into from
May 23, 2019

Conversation

nathancharles
Copy link
Contributor

When there is only a single filter active in the columns config, use a single column for the filter grid list columns. This will allow the filter to take up 100% of the filter popover width.

Fixes: #604

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 77.022% when pulling fa8ca73 on nathancharles:filterWidths into 267c4cd on gregnb:master.

@gabrielliwerant gabrielliwerant self-requested a review May 21, 2019 20:32
@gabrielliwerant gabrielliwerant added needs review Useful to mark PRs for what's up next to review and removed needs review Useful to mark PRs for what's up next to review labels May 21, 2019
Copy link
Collaborator

@gabrielliwerant gabrielliwerant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you for working on this issue!

Will add this to the next release.

@gabrielliwerant gabrielliwerant merged commit d137bd5 into gregnb:master May 23, 2019
bzemms added a commit to dome9/mui-datatables that referenced this pull request Jun 2, 2019
* master:
  2.3.0
  Update package lockfile and prettify files
  Allow search bar to be shown when switching between toolbars (gregnb#654)
  Improve grid spacing in filters dialog (gregnb#640)
  fix renderMultiselect filter type for null values (gregnb#624)
  add onTableInit callback (gregnb#622)
  Bugfix/remove deprecated rollup config option (gregnb#641)
  Bugfix/search text issues (gregnb#647)
  Bugfix/issue 587 fix duplicate call (gregnb#631)
  Single grid column for single filter (gregnb#613)
  header wrap fix (gregnb#629)
  published version 2.2.0
  Add documentation for how to hide column from 'View column' list (gregnb#43) (gregnb#609)
  Bugfix/issues 561 and 600 toolbar problems (gregnb#606)
  Add searchText option to initialise datatable with search text (gregnb#603)
  customRowRender (gregnb#589)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single filters have 50% width
3 participants