Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

header wrap fix #629

Merged
merged 3 commits into from
May 23, 2019
Merged

header wrap fix #629

merged 3 commits into from
May 23, 2019

Conversation

amacwhirter
Copy link
Contributor

Possible solution to issue #611

@coveralls
Copy link

coveralls commented May 18, 2019

Coverage Status

Coverage remained the same at 77.323% when pulling e71713d on amacwhirter:master into bab1fcc on gregnb:master.

@gabrielliwerant gabrielliwerant self-requested a review May 20, 2019 03:36
@gabrielliwerant gabrielliwerant added the needs review Useful to mark PRs for what's up next to review label May 20, 2019
Copy link
Collaborator

@gabrielliwerant gabrielliwerant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me, nice job! Just one small change needed with the positioning of the closing bracket.

src/components/TableHeadCell.js Outdated Show resolved Hide resolved
@gabrielliwerant gabrielliwerant added needs work and removed needs review Useful to mark PRs for what's up next to review labels May 21, 2019
@gabrielliwerant
Copy link
Collaborator

Fixes #611.

@gabrielliwerant
Copy link
Collaborator

Looks good, thank you @amacwhirter! I will add this to the next release.

@gabrielliwerant gabrielliwerant merged commit e26efad into gregnb:master May 23, 2019
@KasparasGud
Copy link

Thank you @amacwhirter 💪

bzemms added a commit to dome9/mui-datatables that referenced this pull request Jun 2, 2019
* master:
  2.3.0
  Update package lockfile and prettify files
  Allow search bar to be shown when switching between toolbars (gregnb#654)
  Improve grid spacing in filters dialog (gregnb#640)
  fix renderMultiselect filter type for null values (gregnb#624)
  add onTableInit callback (gregnb#622)
  Bugfix/remove deprecated rollup config option (gregnb#641)
  Bugfix/search text issues (gregnb#647)
  Bugfix/issue 587 fix duplicate call (gregnb#631)
  Single grid column for single filter (gregnb#613)
  header wrap fix (gregnb#629)
  published version 2.2.0
  Add documentation for how to hide column from 'View column' list (gregnb#43) (gregnb#609)
  Bugfix/issues 561 and 600 toolbar problems (gregnb#606)
  Add searchText option to initialise datatable with search text (gregnb#603)
  customRowRender (gregnb#589)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants