Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

string does not have items #553

Merged
merged 5 commits into from Nov 3, 2023
Merged

Conversation

gregsdennis
Copy link
Owner

Resolves #551

Copy link

github-actions bot commented Nov 3, 2023

Test Results

       14 files  ±0         14 suites  ±0   14s ⏱️ -5s
18 864 tests +1  17 525 ✔️ +1  1 339 💤 ±0  0 ±0 
19 236 runs  +1  17 849 ✔️ +1  1 387 💤 ±0  0 ±0 

Results for commit d0710e7. ± Comparison against base commit 9771c71.

This pull request removes 8 and adds 3 tests. Note that renamed tests count towards both.
    "other string"
    "string",
    42
  "foo": [
  ]
Json.Schema.Tests.CrossDraftTests ‑ ArrayItemsIsAllowedForDraft7({
},False)
},True)
Json.Schema.Generation.Tests.ClientTests ‑ Issue551_MinMaxItemsOnStringProperty
Json.Schema.Tests.CrossDraftTests ‑ ArrayItemsIsAllowedForDraft7({
  "foo": [
    "string",
    "other string"
  ]
},False)
Json.Schema.Tests.CrossDraftTests ‑ ArrayItemsIsAllowedForDraft7({
  "foo": [
    "string",
    42
  ]
},True)

♻️ This comment has been updated with latest results.

@gregsdennis gregsdennis merged commit 3e37380 into master Nov 3, 2023
6 checks passed
@gregsdennis gregsdennis deleted the schemagen/string-does-not-have-items branch November 3, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MinItems and MaxItems attributes generates invalid schema inside array type items of strings
1 participant