string does not have items

JsonSchema.Generation.Tests/ClientTests.cs

@@ -324,4 +324,28 @@ public void Issue544_DeprecatedSpillingOverToOtherPropertiesOfSameType()
 		Assert.AreEqual(1, schema.GetProperties()!["BBB"].Keywords!.Count);
 		Assert.AreEqual("type", schema.GetProperties()!["BBB"].Keywords!.First().Keyword());
 	}
+
+	private class Type551_MinItemsOnString
+	{
+		[MinItems(1)]
+		[MaxItems(10)]
+		public string Value { get; set; }
+	}
+
+	[Test]
+	public void Issue551_MinMaxItemsOnStringProperty()
+	{
+		JsonSchema expected = new JsonSchemaBuilder()
+			.Type(SchemaValueType.Object)
+			.Properties(
+				("Value", new JsonSchemaBuilder().Type(SchemaValueType.String))
+			);
+
+		JsonSchema schema = new JsonSchemaBuilder().FromType<Type551_MinItemsOnString>();
+		var schemaJson = JsonSerializer.Serialize(schema, new JsonSerializerOptions { WriteIndented = true });
+		Console.WriteLine(schemaJson);
+
+		Assert.AreEqual(1, schema.GetProperties()!["Value"].Keywords!.Count);
+		Assert.AreEqual("type", schema.GetProperties()!["Value"].Keywords!.First().Keyword());
+	}
 }

JsonSchema.Generation/JsonSchema.Generation.csproj

@@ -19,8 +19,8 @@
 		<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
 		<DocumentationFile>JsonSchema.Net.Generation.xml</DocumentationFile>
 		<LangVersion>latest</LangVersion>
-		<Version>3.4.1</Version>
-		<FileVersion>3.4.1.0</FileVersion>
+		<Version>3.4.2</Version>
+		<FileVersion>3.4.2.0</FileVersion>
 		<AssemblyVersion>3.0.0.0</AssemblyVersion>
 		<IncludeSymbols>true</IncludeSymbols>
 		<SymbolPackageFormat>snupkg</SymbolPackageFormat>

JsonSchema.Generation/TypeExtensions.cs

@@ -20,9 +20,10 @@ public static class TypeExtensions
 	/// <returns>true if the type represents an array; false otherwise.</returns>
 	public static bool IsArray(this Type type)
 	{
-		return type.IsArray ||
-			   type == typeof(Array) ||
-			   typeof(IEnumerable).IsAssignableFrom(type);
+		return type != typeof(string) &&
+		       (type.IsArray ||
+		        type == typeof(Array) ||
+		        typeof(IEnumerable).IsAssignableFrom(type));
 	}
 
 	internal static int GetAttributeSetHashCode(this IEnumerable<Attribute> items)

tools/ApiDocsGenerator/release-notes/rn-json-schema-generation.md

@@ -4,6 +4,10 @@ title: JsonSchema.Net.Generation
 icon: fas fa-tag
 order: "8.02"
 ---
+# [3.4.2](https://github.com/gregsdennis/json-everything/pull/553) {#release-schemagen-3.4.2}
+
+[#551](https://github.com/gregsdennis/json-everything/issues/551) - Strings implement `IEnumerable<T>` and thus were considered arrays.  As a result `minItems` and `maxItems` were being applied.  Thanks to [@domchlouba](https://github.com/domchlouba) for reporting this and recommending the fix.
+
 # [3.4.1](https://github.com/gregsdennis/json-everything/pull/546) {#release-schemagen-3.4.1}
 
 [#544](https://github.com/gregsdennis/json-everything/issues/544) - Objects that have two properties of the same type, one of which is marked with an `[Obsolete]` attribute will cause all properties to have a `deprecated: true` added to their schemas.  Thanks to [@filzrev](https://github.com/filzrev) for reporting this.