Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make thumbnail generation threaded #32

Closed
gregzaal opened this issue Jan 26, 2017 · 3 comments
Closed

Make thumbnail generation threaded #32

gregzaal opened this issue Jan 26, 2017 · 3 comments

Comments

@gregzaal
Copy link
Owner

Much of the time seems to be spent loading and reading the hdr file, which uses only one thread. Multiple thumbnails could be generated simultaneously.

@gregzaal gregzaal added this to the v3.0 milestone Jan 26, 2017
@gregzaal
Copy link
Owner Author

Main concern is memory limitation - huge HDRIs can fill up all the memory during thumbnail generation (since it has to be stored in memory several times) - maybe there's a way to check how much memory is available and only add to the thread pool when there is enough available.

@gregzaal gregzaal modified the milestones: v3.1, v3.0 Feb 4, 2017
@gregzaal
Copy link
Owner Author

gregzaal commented Feb 4, 2017

This can wait until the next release - for now just getting thumbnails from a server (#35) will be enough.

@gregzaal
Copy link
Owner Author

It's already threaded...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant