Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter Darkened JPG generation #58

Open
gregzaal opened this issue Feb 20, 2017 · 0 comments
Open

Smarter Darkened JPG generation #58

gregzaal opened this issue Feb 20, 2017 · 0 comments

Comments

@gregzaal
Copy link
Owner

At the moment all darkened JPGs are darkened by the same amount.

Some HDRIs have weak or large light sources, so darkening them by the same consistent amount might put their brightest value below 1.0, meaning there'd be unnecessary banding.

For such cases, only darken them until the brightest pixel is at 1.0. A list of the amount each HDRI is darkened would have to be stored so that they can be brightened by the same amount later.

We could maybe do all HDRIs like this (even very bright ones), but then we'd have to do per-case gamma adjustments to avoid excessive banding in the shadows.

@gregzaal gregzaal added this to the v3.1 milestone Feb 20, 2017
@gregzaal gregzaal modified the milestones: v3.1, v3.2 Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant