Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to drop multiple tables #4020

Closed
WenyXu opened this issue May 23, 2024 · 6 comments · Fixed by #4085
Closed

Support to drop multiple tables #4020

WenyXu opened this issue May 23, 2024 · 6 comments · Fixed by #4085
Assignees
Labels
C-feature Category Features good first issue Good for newcomers

Comments

@WenyXu
Copy link
Member

WenyXu commented May 23, 2024

What problem does the new feature solve?

Drop multiple tables in the single statement

What does the feature do?

To implement the DROP [TEMPORARY] TABLE [IF EXISTS] tbl_name [, tbl_name]

Implementation challenges

No response

@WenyXu WenyXu added good first issue Good for newcomers C-feature Category Features labels May 23, 2024
@sarailQAQ
Copy link
Contributor

Can I try it?

@sarailQAQ
Copy link
Contributor

I have a question: When an error occurs while dropping multiple tables, what action should I take?

  • Attempt to drop the remaining tables and then, finally, return an error message. Or,
  • Immediately abort the process of dropping tables and return an error?

@WenyXu
Copy link
Member Author

WenyXu commented May 30, 2024

I have a question: When an error occurs while dropping multiple tables, what action should I take?

  • Attempt to drop the remaining tables and then, finally, return an error message. Or,
  • Immediately abort the process of dropping tables and return an error?

I prefer the first one.

@sarailQAQ
Copy link
Contributor

I have a question: When an error occurs while dropping multiple tables, what action should I take?

  • Attempt to drop the remaining tables and then, finally, return an error message. Or,
  • Immediately abort the process of dropping tables and return an error?

I prefer the first one.

There is another question: in more extreme cases, if multiple errors occur, how do I deal with these errors?

@WenyXu
Copy link
Member Author

WenyXu commented May 30, 2024

There is another question: in more extreme cases, if multiple errors occur, how do I deal with these errors?

How about referencing the behavior of the MySQL.

@sarailQAQ
Copy link
Contributor

sarailQAQ commented May 30, 2024

How about referencing the behavior of the MySQL.

If any tables do not exist without IF EXISTS, the statement fails with an error and don`t make any change. It`s obvious, and I`m implementing it.

For other internal errors might occur, it has no discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category Features good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants