-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nicer node printing & summary methods #22
Comments
'Node' isn't the best name for these (and it's confusing as nodes are defined internally, too). 'Tensor' may also be confused with TF tensors. Since they are intended to behave like arrays, perhaps 'greta array' is a better term? The print method might then give:
for consistency, and to hide internal functions from users, it might be better to thinly wrap these in a |
ideas for the |
implemented in #24 |
Printing nodes should say that they are greta nodes and preferably state the node type.
For data nodes, which have fixed values, they should summarise the data as if they were arrays (but with
drop = FALSE
). For stochastic or op nodes, they should summarise the data shape and print that with?
entries.This gist defines an array-like class for unknown values, with subsetting methods etc. This can be used to overload
head()
for nodes. Printing would look like this:A
dim()
method (just returningx$dim
), would also be helpful.summary()
andstr()
methods for distribution nodes should also return some information about the distributions and possibly parameters.The text was updated successfully, but these errors were encountered: