Customisable measure data domain style

[ericneiva]

Solves #877.

After discussion with @santiagobadia, I have changed the CellQuadrature constructors such that now both data and integration domain styles are keyword arguments that the user can customise.

Note that this PR introduces a minor change in the API.

[codecov-commenter]

Codecov Report

Merging #885 (38ab651) into master (4825525) will increase coverage by 0.03%.
The diff coverage is 85.71%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #885      +/-   ##
==========================================
+ Coverage   88.50%   88.53%   +0.03%     
==========================================
  Files         172      172              
  Lines       20121    20107      -14     
==========================================
- Hits        17808    17802       -6     
+ Misses       2313     2305       -8     

Impacted Files	Coverage Δ
src/CellData/CellQuadratures.jl	86.25% <85.00%> (+6.46%)	⬆️
src/Adaptivity/CompositeQuadratures.jl	86.84% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[amartinhuertas]

Hi @ericneiva ! Thanks for the PR. I agree the API is much cleaner now.

My only concern is that if we accept the PR as it is, then we should also do major release, correct?

Can we may be add the old signatures and add corresponding deprecated warnings so that we avoid a major release?

Also note that, since this PR (my fault sorry), we also added another kind of measure, called CompositeMeasure, which is leveraged whenever you have integration on adapted meshes. Not sure if this has to be taken into account when updating this branch from master ...

[amartinhuertas]

Also note that, since this PR (my fault sorry), we also added another kind of measure, called CompositeMeasure, which is leveraged whenever you have integration on adapted meshes. Not sure if this has to be taken into account when updating this branch from master ...

Forget this. I now see you are already taking into account CompositeMeasure in your PR ...

[amartinhuertas]

Also dont forget to add the corresponding entry in NEWS.md ... Thanks!

[ericneiva]

Hi, @amartinhuertas,

I agree the API is much cleaner now.

Good to know :)

Can we may be add the old signatures and add corresponding deprecated warnings so that we avoid a major release?

Done. Let me know if the deprecated warnings are ok.

Also dont forget to add the corresponding entry in NEWS.md

Done.

Thank you very much for your review!

[amartinhuertas]

FYI, just in case you did not know, I found this article on deprecation quite useful:

https://invenia.github.io/blog/2022/06/17/deprecating-in-julia/

All good now. Accepting PR!

[ericneiva]

Great, thanks!

FYI, just in case you did not know, I found this article on deprecation quite useful:

Useful, indeed, thanks for sharing, @amartinhuertas