Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to PartitionedArrays v0.3 #170

Merged
merged 4 commits into from
Aug 23, 2023

Conversation

JordiManyer
Copy link
Member

This PR fixes the distributed tutorials following the updates to PartitionedArrays.jl v0.3

@JordiManyer
Copy link
Member Author

Hi @ericneiva @amartinhuertas ,

The latest changes that Eric introduced to CellQuadrature in PR 885 break the low-level tutorial (as you can see in the CI tests).
This is due to CellQuadrature no longer implementing the CellDatum API correctly, mainly the DomainStyle method.

We can either change the tutorial (and illustrate the DomainStyle feature with another CellDatum structure) or add back the method for CellQuadrature.

How do you want to proceed?

@ericneiva
Copy link
Member

ericneiva commented Aug 22, 2023

Hi, @JordiManyer, thanks for reporting this.

I overlooked it completely because, as you can imagine, I didn't run the tutorials before merging that PR (sorry about that).

I removed the DomainStyle signature in PR 885, namely,

DomainStyle(::Type{CellQuadrature{DDS,IDS}}) where {DDS,IDS} = DDS()

because, as a CellQuadrature has two DomainStyle attributes (data and integration), I found it a little confusing.

However, if I look at the doc of DomainStyle(), the signature still makes sense because the arrays of CellQuadrature are always stored in the DomainStyle of the data.

We can either change the tutorial (and illustrate the DomainStyle feature with another CellDatum structure) or add back the method for CellQuadrature.

I'd do the latter :)

@JordiManyer
Copy link
Member Author

Hi @ericneiva ,

Great! Once you have the PR in Gridap, @amartinhuertas can do the release. It might take a week since he is away atm. Once we have a new release I'll merge this PR.

@JordiManyer JordiManyer marked this pull request as ready for review August 23, 2023 05:33
@amartinhuertas amartinhuertas merged commit 9bd0683 into gridap:master Aug 23, 2023
6 checks passed
@JordiManyer JordiManyer deleted the partitioned-arrays-v0.3 branch August 23, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants