Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement DomainStyle for CellQuadrature #937

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

ericneiva
Copy link
Member

This PR fixes the low-level tutorial, breaking due to #885, as noted by @JordiManyer (thanks).

See here for details.

@amartinhuertas, could you please review and accept, whenever you have some time? Thanks.

@codecov-commenter
Copy link

Codecov Report

Merging #937 (2f3aa26) into master (ffe4667) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 2f3aa26 differs from pull request most recent head 152aaeb. Consider uploading reports for the commit 152aaeb to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #937      +/-   ##
==========================================
- Coverage   88.43%   88.43%   -0.01%     
==========================================
  Files         174      174              
  Lines       20626    20627       +1     
==========================================
  Hits        18241    18241              
- Misses       2385     2386       +1     
Files Changed Coverage Δ
src/CellData/CellQuadratures.jl 85.18% <0.00%> (-1.07%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JordiManyer JordiManyer merged commit 52ee5ce into master Aug 23, 2023
7 checks passed
@JordiManyer JordiManyer deleted the reimplement_DomainStyle_for_CellQuadrature branch August 23, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants