Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work on branch cell_values_and_cell_maps_refactoring #17

Closed
fverdugo opened this issue May 8, 2019 · 3 comments
Closed

Work on branch cell_values_and_cell_maps_refactoring #17

fverdugo opened this issue May 8, 2019 · 3 comments

Comments

@fverdugo
Copy link
Member

fverdugo commented May 8, 2019

Misc. comments on the developments done at branch cell_values_and_cell_maps_refactoring
@fverdugo
Copy link
Member Author

fverdugo commented May 8, 2019 •
edited
Loading

  • I have decided to delete IterCellData and flatten(::CellArray) from CellValues, since they are only used as low level helpers in Vtkio. They (or equivalent functionality) have to be moved to the latter module

@fverdugo
Copy link
Member Author

fverdugo commented May 9, 2019

For the moment, I will not introduce the inconsistency between inner and varinner

Custom broadcasting in Map missing

fverdugo referenced this issue May 13, 2019
@fverdugo
Merge pull request #18 from lssc-team/cell_values_and_cell_maps_refac…
b338592 
…toring

Cell values and cell maps refactoring
@fverdugo
Copy link
Member Author

fverdugo commented May 13, 2019 •
edited
Loading

This work finished with PR #18
closing issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fverdugo