myproxy-logon still returns code 0 when voms-proxy-init called by it fails

[zsalvet]

Return value from voms_proxy_init() is checked for negative values instead of non-zero values.

[msalle]

To document the issue:
The problem comes from myproxy_get_delegation.c lines 205-210 where a warning is logged in case the voms-proxy-init command failed, but it does not influence the exit value. (Note that the actual call and waitpid() is in at the end of the same file myproxy_get_delegation.c lines 506-L510). So when the voms-proxy-init command fails, you get a warning and instead a non-voms proxy is successfully issued, hence you get the 0 exit value. We should decide whether we find this behaviour correct (in which case it probably must be documented) or a bug.

[zsalvet]

The second part of the problem is lack of proper handling of "rc" returned by the waitpid(),
it needs to be interpreted (at least WIFEXITED and WIFSIGNALED cases) and replaced
with suitable negative value before return from voms_proxy_init().

[msalle]

I agree that returning the status as rc is incorrect, but in any case, any return value of voms_proxy_init() is currently ignored. Parsing the status to produce better (and correct) logging would indeed be a good idea.

[fscheiner]

@zsalvet @msalle
@jbasney and me have provided #147 to solve this issue. This should automatically close this issue when merged. If the provided solution is not what you had in mind or incomplete, please re-open this issue and provide an explanation.

[fscheiner]

Ok, as per #129 I label this issue "fixed in git master", re-open it and keep it open until our next release.

[fscheiner]

Fixed in GCT 6.2.20210826 maintenance release.