Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Use newest config.{guess,sub} available #2722

Merged
merged 2 commits into from
Dec 10, 2023

Conversation

div72
Copy link
Member

@div72 div72 commented Dec 7, 2023

ea7b8528490d330f0f4e34e9b26ab00ba528f546 build: Use newest config.{guess,sub} available (Hennadii Stepanov)

Pull request description:

Fixes cross-compiling on old systems. See bitcoin/bitcoin#26420 (comment).

Guix builds:

ab58f8db4fb50c2af08be646e4a57491ff853bf41319fe3e962bb928ace2c1be  guix-build-ea7b8528490d/output/aarch64-linux-gnu/SHA256SUMS.part
c4a42a7dbfb15aa910ce269c3f3158df758eba01dd855cf6529c960d9b8bd76b  guix-build-ea7b8528490d/output/aarch64-linux-gnu/bitcoin-ea7b8528490d-aarch64-linux-gnu-debug.tar.gz
add5f80b0c8ee216c1d8db31e13656c45f11fe5c967324b8fcedd64d0d408938  guix-build-ea7b8528490d/output/aarch64-linux-gnu/bitcoin-ea7b8528490d-aarch64-linux-gnu.tar.gz
ba807ae5b29aca611a35700a968a4f9010528d6cdb6412f98c707aa0e9510e8b  guix-build-ea7b8528490d/output/arm-linux-gnueabihf/SHA256SUMS.part
fe127eff1fc8389ef00ae39d1446640512120d2f247a2ee64c06290116265729  guix-build-ea7b8528490d/output/arm-linux-gnueabihf/bitcoin-ea7b8528490d-arm-linux-gnueabihf-debug.tar.gz
ac75f0aba2e0801fc6b59405bff09884837e0ff8b6fa9fc1225e8325a4ec78a4  guix-build-ea7b8528490d/output/arm-linux-gnueabihf/bitcoin-ea7b8528490d-arm-linux-gnueabihf.tar.gz
dee402db94829bd5ce029ca02d75e008f8a18a44fd88e8ecd00b3ce586f223f4  guix-build-ea7b8528490d/output/arm64-apple-darwin/SHA256SUMS.part
bbf985dbd1ca875fbb0a03c21698d4b6797c27be45e3a31a3229daee0ecbcbf4  guix-build-ea7b8528490d/output/arm64-apple-darwin/bitcoin-ea7b8528490d-arm64-apple-darwin-unsigned.dmg
3cca89e532a2b637185ca316168b0f6fac2fce8795b486d530ee966a844716f1  guix-build-ea7b8528490d/output/arm64-apple-darwin/bitcoin-ea7b8528490d-arm64-apple-darwin-unsigned.tar.gz
487c68e1a71f6254d48f8d322a46c94e671e00b5930fbfe689804cd8e379c8e9  guix-build-ea7b8528490d/output/arm64-apple-darwin/bitcoin-ea7b8528490d-arm64-apple-darwin.tar.gz
db663cf3216871f4c87b687a839cb5cf18b5d9906b74d4c19e8ad422d904aa87  guix-build-ea7b8528490d/output/dist-archive/bitcoin-ea7b8528490d.tar.gz
09121bcd36d72ad26364182c678f2edaaf5b5e635ed43a6964ad7e4be1335075  guix-build-ea7b8528490d/output/powerpc64-linux-gnu/SHA256SUMS.part
e8638959b501c3d70421dcdc6579c5d77c5786abed7ad3d6051c628fd8f17c6b  guix-build-ea7b8528490d/output/powerpc64-linux-gnu/bitcoin-ea7b8528490d-powerpc64-linux-gnu-debug.tar.gz
b1aee39067d5010b4e63dc916232eb1582299d7acb56afacf5c9a5b75dcd8b82  guix-build-ea7b8528490d/output/powerpc64-linux-gnu/bitcoin-ea7b8528490d-powerpc64-linux-gnu.tar.gz
9ed3d0e710847068cb2064e51e3f4c14166ad86f5c297adcf0a4d24cd4e2a723  guix-build-ea7b8528490d/output/powerpc64le-linux-gnu/SHA256SUMS.part
19f99e41f41d9525a412872e61687452ab5ac23c5c964ef34b8c31a9d71adabc  guix-build-ea7b8528490d/output/powerpc64le-linux-gnu/bitcoin-ea7b8528490d-powerpc64le-linux-gnu-debug.tar.gz
bd669150ce6830ffbd8523acf75b6daf894c9449c6ce3073a9ce89156d9268f9  guix-build-ea7b8528490d/output/powerpc64le-linux-gnu/bitcoin-ea7b8528490d-powerpc64le-linux-gnu.tar.gz
5e42cb1fee7b5b046da37f62674a1662a6135f9644f5ea0288876334c3e8d34a  guix-build-ea7b8528490d/output/riscv64-linux-gnu/SHA256SUMS.part
8767a84e04e0cd27318305d31a5a897cdc5f56d8505416dd01753bb35c8980b0  guix-build-ea7b8528490d/output/riscv64-linux-gnu/bitcoin-ea7b8528490d-riscv64-linux-gnu-debug.tar.gz
00f1abcc64a7010f194dab847c04481e10991128b919b513aa9eb2911d03a243  guix-build-ea7b8528490d/output/riscv64-linux-gnu/bitcoin-ea7b8528490d-riscv64-linux-gnu.tar.gz
ae7add2e3ea0663fdd9d2c61c737e4bb4155d42932a0a5ce8cbbbcee627f01f3  guix-build-ea7b8528490d/output/x86_64-apple-darwin/SHA256SUMS.part
ba6b4a2f6a97e382a10ffec605f025d8724ac2dc0a441dbb42be79e915e98738  guix-build-ea7b8528490d/output/x86_64-apple-darwin/bitcoin-ea7b8528490d-x86_64-apple-darwin-unsigned.dmg
67914f29d9e81ee50b340c3ac05b336b98766b59b8cce153493786b04a51f18a  guix-build-ea7b8528490d/output/x86_64-apple-darwin/bitcoin-ea7b8528490d-x86_64-apple-darwin-unsigned.tar.gz
1d813d0e905a324f48beb2ce1da980e372c529b0eadb521662063f283fbc9bf6  guix-build-ea7b8528490d/output/x86_64-apple-darwin/bitcoin-ea7b8528490d-x86_64-apple-darwin.tar.gz
4e3d176ad9059e59e9b21919001ced2710c74229536b27ef65acef514287f7e5  guix-build-ea7b8528490d/output/x86_64-linux-gnu/SHA256SUMS.part
cbe31f4a60aac1a72bcdedccf39c18da21a5a4e257e77c0832ad93ce722923dd  guix-build-ea7b8528490d/output/x86_64-linux-gnu/bitcoin-ea7b8528490d-x86_64-linux-gnu-debug.tar.gz
d5f3cf53adf1d964cded3461b66199c4917715af0d84cac78c97acc92432b059  guix-build-ea7b8528490d/output/x86_64-linux-gnu/bitcoin-ea7b8528490d-x86_64-linux-gnu.tar.gz
9b1877d00fd447222839615cfeb089a8237f1d5d80cd2b819dd66621df8f2375  guix-build-ea7b8528490d/output/x86_64-w64-mingw32/SHA256SUMS.part
2fb88e40dd399a2dedb1a44c5bd1091899b00a6d3b8d99149f622a0069205560  guix-build-ea7b8528490d/output/x86_64-w64-mingw32/bitcoin-ea7b8528490d-win64-debug.zip
074ce203494dc15c916c151426438f09982a270f389cd139d3f28a75aea51af8  guix-build-ea7b8528490d/output/x86_64-w64-mingw32/bitcoin-ea7b8528490d-win64-setup-unsigned.exe
2aa8ff735ce96580fb915757ccce79dc2a19afb043a6c93d3749023ca647666d  guix-build-ea7b8528490d/output/x86_64-w64-mingw32/bitcoin-ea7b8528490d-win64-unsigned.tar.gz
0ac19e1901506c47d5b20297d468dbaa93e8572232671a16d08355988df8e7c3  guix-build-ea7b8528490d/output/x86_64-w64-mingw32/bitcoin-ea7b8528490d-win64.zip

ACKs for top commit:
fanquake:
ACK ea7b8528490d330f0f4e34e9b26ab00ba528f546

Tree-SHA512: 75c154d2195e2e8cf2e2786c08bc5096b07027715f559fc81c1ce221ce74c2732e745b74809d7c4a9f909a1018399a07329abd993e50ecec91dd95518fce0b39

hebasto and others added 2 commits December 3, 2023 17:28
Since ea7b8528 (#26422), autogen.sh overwrites the
build-aux/config.{guess, sub} files (installed there by autoreconf)
with the depends/config.{guess, sub} files if these are newer.

The autoreconf tool copies them from it's share/autoconf/build-aux/
directory. Specifically on NixOS, the share/autoconf/build-aux/
files are located in the nix-store and are read-only. autoreconf
preserves the read-only permissions when copying. Overwriting them
with our depends/config.{guess, sub} subsequently fails.

To make sure we can overwrite the files, we set write permissions to
the current user and group before overwriting. This fixes the problem
on NixOS.

fixes #27873: Can't copy to 'build-aux/config.guess' in autoconf.sh: Permission denied
Copy link
Member

@jamescowens jamescowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jamescowens jamescowens merged commit f82e653 into gridcoin-community:development Dec 10, 2023
17 checks passed
jamescowens added a commit to jamescowens/Gridcoin-Research that referenced this pull request Mar 2, 2024
Added
 - contrib: add nix file for compilation environment gridcoin-community#2660 (@div72)
 - gui: Make main Gridcoin window geometry save unique to datadir location gridcoin-community#2661 (@jamescowens)
 - build: Initial CMake support gridcoin-community#2676 (@CyberTailor)
 - util: Add `-shutdownnotify` and `startupnotify` options from upstream gridcoin-community#2688 (@barton2526)
 - gui, staking: Implement facilities for mandatory sidestakes and sidestake GUI gridcoin-community#2704 (@jamescowens)
 - gui, voting: Implement poll result caching and poll stale indicator gridcoin-community#2709 (@jamescowens)
 - gui, projects: Implement greylist state for projects in GUI projects table gridcoin-community#2715 (@jamescowens)
 - gui, poll: Implement poll expiration reminders gridcoin-community#2716 (@jamescowens)
 - serialize: allow variants to be serialized gridcoin-community#2729 (@div72)
 - gui: Implement poll field length limiters in GUI forms gridcoin-community#2742 (@jamescowens)

Changed
 - consensus, contract, scraper, protocol, project, beacon, rpc: Replace remaining appcache sections with native structures gridcoin-community#2639 (@jamescowens)
 - build: update libsecp256k1 to v0.3.0 gridcoin-community#2655 (@div72)
 - build: Replace $(AT) with .SILENT gridcoin-community#2674 (@barton2526)
 - build: allow system bdb gridcoin-community#2675 (@div72)
 - Resize Header Column with Additional Text gridcoin-community#2683 (@PrestackI)
 - rpc: use RPCErrorCode everywhere gridcoin-community#2687 (@Pythonix)
 - wallet: SecureString to allow null characters gridcoin-community#2690 (@barton2526)
 - random: port some upstream changes gridcoin-community#2696 (@div72)
 - depends: Bump dependencies gridcoin-community#2692 (@barton2526)
 - doc: Update link to Discord server gridcoin-community#2693 (@adriaanjoubert)
 - rpc: Change capitalization, remove whitespace of rpc keys gridcoin-community#2711 (@Pythonix)
 - ci: bump MacOS version to 12 gridcoin-community#2713 (@div72)
 - depends: no-longer nuke libc++abi.so* in native_clang package gridcoin-community#2719 (@div72)
 - doc: update windows `-fstack-clash-protection` doc gridcoin-community#2720 (@div72)
 - Silence `-Wcast-function-type` warning gridcoin-community#2721 (@div72)
 - build: Use newest `config.{guess,sub}` available gridcoin-community#2722 (@div72)
 - refactor: use the try_lock result in TryEnter gridcoin-community#2723 (@div72)
 - Updates for file src/qt/locale/bitcoin_en.ts in pt_PT gridcoin-community#2726 (@gridcoin-community)
 - ci: do not silently fail gridcoin-community#2727 (@div72)
 - Properly include Boost Array header gridcoin-community#2730 (@theMarix)
 - build: Update depends zlib to 1.3.1 gridcoin-community#2734 (@jamescowens)
 - util: Enhance Fraction class overflow resistance gridcoin-community#2735 (@jamescowens)
 - refactor: Fix compilation warnings gridcoin-community#2737 (@jamescowens)
 - gui, util: Improve upgrade dialog gridcoin-community#2738 (@jamescowens)
 - util: Improve allocation class gridcoin-community#2740 (@jamescowens)
 - translations: translation updates for Miss Piggy release gridcoin-community#2745 (@jamescowens)

Removed
 - gui: Disable snapshot GUI action gridcoin-community#2700 (@jamescowens)
 - build, crypto, script: remove most of OpenSSL usage gridcoin-community#2705 (@div72)
 - util: remove WSL 1 workaround in fs gridcoin-community#2717 (@div72)

Fixed
 - diagnostics: fix missing arg in ETTS warning gridcoin-community#2684 (@div72)
 - misc: fix include guard in netaddress.h gridcoin-community#2695 (@div72)
 - gui: Fix expired pending beacon display gridcoin-community#2698 (@jamescowens)
 - consensus: Fix 20230904 testnet forking issue gridcoin-community#2703 (@jamescowens)
 - gui: Fix filter by type in Transaction View gridcoin-community#2708 (@jamescowens)
 - depends: make fontconfig build under clang-16 gridcoin-community#2718 (@div72)
 - diag: fix researcher mode check gridcoin-community#2725 (@div72)
 - gui: Add missing switch cases for ALREADY_IN_MEMPOOL gridcoin-community#2728 (@jamescowens)
 - beacon, registry: Fix beacon history stall gridcoin-community#2731 (@jamescowens)
 - build: Implement comp_double comparison function in certain tests gridcoin-community#2741 (@jamescowens)
 - ci: change Qt path in CMake CI gridcoin-community#2743 (@div72)
 - net: Correct -tor argument handling gridcoin-community#2744 (@jamescowens)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants