Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly include Boost Array header #2730

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Properly include Boost Array header #2730

merged 2 commits into from
Dec 29, 2023

Conversation

theMarix
Copy link
Contributor

With Boost 1.84 the Boost Array header no longer seems to be implicitly
included by other Boost headers we are using. Thus, our usages of
boost::array run into an incomplete type.

This includes boost/array.hpp everywhere we explicitly use boost::array
to ensure we do not depend on implicit includes.

@theMarix
Properly include Boost Array header
c3377e6 
With Boost 1.84 the Boost Array header no longer seems to be implicitly
included by other Boost headers we are using. Thus, our usages of
boost::array run into an incomplete type.

This includes boost/array.hpp everywhere we explicitly use boost::array
to ensure we do not depend on implicit includes.
@theMarix
Copy link
Contributor Author

Not sure what to do about that lint error. It fails because I supposedly added a dependency on Boost Arrray. However, that dependency was already used, I only seem to have to have made it explicit by adding the proper include.

@jamescowens
Copy link
Member

Ah. There is something we have to change in the linter config files to fix this. I will take a look. :)

@jamescowens
Copy link
Member

Hey @theMarix. I think if you add this dependency to Gridcoin-Research/test/lint/lint-includes.sh under the section EXPECTED_BOOST_INCLUDES it should clear the lint error.

@theMarix
Copy link
Contributor Author

Hey @theMarix. I think if you add this dependency to Gridcoin-Research/test/lint/lint-includes.sh under the section EXPECTED_BOOST_INCLUDES it should clear the lint error.

I'll give it a try. Thanks!

@theMarix
Mark Boost Array's header as an expected include
726cc9e 
We have been using Boost Array already but only indirectly pulled in the
header. Explicit inclusion of the header thus does not introduce any new
dependency.
@theMarix
Copy link
Contributor Author

Hey @theMarix. I think if you add this dependency to Gridcoin-Research/test/lint/lint-includes.sh under the section EXPECTED_BOOST_INCLUDES it should clear the lint error.

I'll give it a try. Thanks!

@jamescowens , thanks for the hint. Tests are now passing.

@jamescowens jamescowens self-requested a review December 29, 2023 03:05
@jamescowens jamescowens added this to the Miss Piggy milestone Dec 29, 2023
jamescowens
jamescowens approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@jamescowens jamescowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jamescowens jamescowens merged commit 5d8153a into gridcoin-community:development Dec 29, 2023
17 checks passed
@theMarix theMarix deleted the boost-1.84-compat branch January 21, 2024 21:29
jamescowens added a commit to jamescowens/Gridcoin-Research that referenced this pull request Mar 2, 2024
@jamescowens
5.4.6.0, 2024-03-02, leisure, "Miss Piggy"
3044941 
Added
 - contrib: add nix file for compilation environment gridcoin-community#2660 (@div72)
 - gui: Make main Gridcoin window geometry save unique to datadir location gridcoin-community#2661 (@jamescowens)
 - build: Initial CMake support gridcoin-community#2676 (@CyberTailor)
 - util: Add `-shutdownnotify` and `startupnotify` options from upstream gridcoin-community#2688 (@barton2526)
 - gui, staking: Implement facilities for mandatory sidestakes and sidestake GUI gridcoin-community#2704 (@jamescowens)
 - gui, voting: Implement poll result caching and poll stale indicator gridcoin-community#2709 (@jamescowens)
 - gui, projects: Implement greylist state for projects in GUI projects table gridcoin-community#2715 (@jamescowens)
 - gui, poll: Implement poll expiration reminders gridcoin-community#2716 (@jamescowens)
 - serialize: allow variants to be serialized gridcoin-community#2729 (@div72)
 - gui: Implement poll field length limiters in GUI forms gridcoin-community#2742 (@jamescowens)

Changed
 - consensus, contract, scraper, protocol, project, beacon, rpc: Replace remaining appcache sections with native structures gridcoin-community#2639 (@jamescowens)
 - build: update libsecp256k1 to v0.3.0 gridcoin-community#2655 (@div72)
 - build: Replace $(AT) with .SILENT gridcoin-community#2674 (@barton2526)
 - build: allow system bdb gridcoin-community#2675 (@div72)
 - Resize Header Column with Additional Text gridcoin-community#2683 (@PrestackI)
 - rpc: use RPCErrorCode everywhere gridcoin-community#2687 (@Pythonix)
 - wallet: SecureString to allow null characters gridcoin-community#2690 (@barton2526)
 - random: port some upstream changes gridcoin-community#2696 (@div72)
 - depends: Bump dependencies gridcoin-community#2692 (@barton2526)
 - doc: Update link to Discord server gridcoin-community#2693 (@adriaanjoubert)
 - rpc: Change capitalization, remove whitespace of rpc keys gridcoin-community#2711 (@Pythonix)
 - ci: bump MacOS version to 12 gridcoin-community#2713 (@div72)
 - depends: no-longer nuke libc++abi.so* in native_clang package gridcoin-community#2719 (@div72)
 - doc: update windows `-fstack-clash-protection` doc gridcoin-community#2720 (@div72)
 - Silence `-Wcast-function-type` warning gridcoin-community#2721 (@div72)
 - build: Use newest `config.{guess,sub}` available gridcoin-community#2722 (@div72)
 - refactor: use the try_lock result in TryEnter gridcoin-community#2723 (@div72)
 - Updates for file src/qt/locale/bitcoin_en.ts in pt_PT gridcoin-community#2726 (@gridcoin-community)
 - ci: do not silently fail gridcoin-community#2727 (@div72)
 - Properly include Boost Array header gridcoin-community#2730 (@theMarix)
 - build: Update depends zlib to 1.3.1 gridcoin-community#2734 (@jamescowens)
 - util: Enhance Fraction class overflow resistance gridcoin-community#2735 (@jamescowens)
 - refactor: Fix compilation warnings gridcoin-community#2737 (@jamescowens)
 - gui, util: Improve upgrade dialog gridcoin-community#2738 (@jamescowens)
 - util: Improve allocation class gridcoin-community#2740 (@jamescowens)
 - translations: translation updates for Miss Piggy release gridcoin-community#2745 (@jamescowens)

Removed
 - gui: Disable snapshot GUI action gridcoin-community#2700 (@jamescowens)
 - build, crypto, script: remove most of OpenSSL usage gridcoin-community#2705 (@div72)
 - util: remove WSL 1 workaround in fs gridcoin-community#2717 (@div72)

Fixed
 - diagnostics: fix missing arg in ETTS warning gridcoin-community#2684 (@div72)
 - misc: fix include guard in netaddress.h gridcoin-community#2695 (@div72)
 - gui: Fix expired pending beacon display gridcoin-community#2698 (@jamescowens)
 - consensus: Fix 20230904 testnet forking issue gridcoin-community#2703 (@jamescowens)
 - gui: Fix filter by type in Transaction View gridcoin-community#2708 (@jamescowens)
 - depends: make fontconfig build under clang-16 gridcoin-community#2718 (@div72)
 - diag: fix researcher mode check gridcoin-community#2725 (@div72)
 - gui: Add missing switch cases for ALREADY_IN_MEMPOOL gridcoin-community#2728 (@jamescowens)
 - beacon, registry: Fix beacon history stall gridcoin-community#2731 (@jamescowens)
 - build: Implement comp_double comparison function in certain tests gridcoin-community#2741 (@jamescowens)
 - ci: change Qt path in CMake CI gridcoin-community#2743 (@div72)
 - net: Correct -tor argument handling gridcoin-community#2744 (@jamescowens)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamescowens jamescowens jamescowens approved these changes

Assignees

@theMarix theMarix

Labels
compatibility
Projects
None yet
Milestone
Miss Piggy
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@theMarix @jamescowens