Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High dpi improvements #517

Merged

Conversation

skcin
Copy link
Contributor

@skcin skcin commented Aug 16, 2017

So far the BOINC logo is replaced by its vector graphics version and the unit of measurement in the stylesheets is switched to svg. The intention is to make the Qt wallet scale on different systems with different DPI values.
@denravonska please don't merge this right away, there is more to come. (besides the merge conflicts)
I plan on putting the new icons/logo in as svg files too. I think the gui should then be tested on different platforms. (and on high dpi displays if anyone got one)

@grctest
Copy link
Contributor

grctest commented Sep 1, 2017

How's this coming along? Since several services began using the new logo, we went live with the new branding/logo on the gridcoin.us website. Don't forget the little grc logo within the msi installer 👍

@grctest
Copy link
Contributor

grctest commented Sep 10, 2017

Branding change applied to slack/telegram/twitter/website/reddit etc. Only the client to go now.

@skcin
Copy link
Contributor Author

skcin commented Sep 12, 2017

I am currently in the process of refining the color schemes. I will commit once it is done.

@skcin
Copy link
Contributor Author

skcin commented Sep 13, 2017

screenshot
screenshot2

@skcin
Copy link
Contributor Author

skcin commented Sep 13, 2017

@grctest do you know where the logo in the msi installer is located in the code?
@Ravon We need to test this on as many platforms as possible. Not sure if svg images behave well.
Would be nice to test this on windows and mac too. There are some people offering testing on high DPI displays but they need binaries. (Mac and Windows)

@tomasbrod
Copy link
Member

That first screen, there contract is too high imo.

@skcin
Copy link
Contributor Author

skcin commented Sep 21, 2017

We should also include @Peppernrino's #628 after this PR to get the icon changes in that I missed. All the .ico and .icns files and everything in share/pixmaps/.

@tomasbrod
Copy link
Member

tomasbrod commented Sep 21, 2017

  • Unlock button does not fit screen (it shows after 5px resize)
  • Scroll-bar appears on bottom of the "Tabs toolbar"
    snimka obrazovky_2017-09-21_20-09-45

@skcin
Copy link
Contributor Author

skcin commented Sep 21, 2017

@tomasbrod do you have a screen shot?

@denravonska
Copy link
Member

@skcin Maybe you should merge @Peppernrino's branch into this one?

@tomasbrod
Copy link
Member

Yup, I just attached it @skcin .

@iFoggz
Copy link
Member

iFoggz commented Sep 22, 2017

itd be nice if someone could modify something so if a message is in the boinchash that it shows something that indicates the tx comes with a message?

@ghost
Copy link

ghost commented Oct 7, 2017

HI, this looks real good. I am happy to help test this on mac book pro high resolution. I have been experimenting with the new logo on my forked repo and have the new purple hex logo running in my dock now. I can submit a pull request for the classic png files until you get the svg issue settled if you wish.

@ghost ghost mentioned this pull request Oct 8, 2017
Change most units of measurement from px to em. Move apperance from .ui
files to stylesheet.
To keep the link to the BOINC homepage a clickable label class is
introduced. The Logo and its size is now defined in the stylesheet.
The Qt version currently used as well as the version the wallet was
built against are shown.
* replace old gridcoin logo with the new one
* replace some key icons with new ones kindly provided by JoShoeAh
* all new icons/images are in svg format
* introduce a dark color scheme
* revise color schemes in collaboration with JoShoeAh
* make the icons switch with the color scheme
* remove obsolete png images

Again, thanks alot JoShoeAh for designing all the artwork.
Peppernrino and others added 5 commits December 8, 2017 18:52
Svg icons were not visible on windows with QIcon.
* make sure all icons change on switch of color scheme
* crop canvas to drawing and remove unnecessary lines from svg images
TheCharlatan and others added 2 commits December 8, 2017 21:52
Adds the ClickLabel class to the qt makefile recipe, removed now unused
.png icon targets.
Add new clicklabel class to qt makefile, remove old .png's
@denravonska denravonska merged commit 1b44a60 into gridcoin-community:development Dec 15, 2017
denravonska pushed a commit that referenced this pull request Jan 10, 2018
This is not to undermine @skcin's great work on pull #517 High dpi improvements. I have replaced the icon, icons, and splash3 png files in order to get our new branding out to the public while using the wallet. The app logo and startup splash screen is the only thing changed. So use if desired.
denravonska pushed a commit that referenced this pull request Jan 13, 2018
This is not to undermine @skcin's great work on pull #517 High dpi improvements. I have replaced the icon, icons, and splash3 png files in order to get our new branding out to the public while using the wallet. The app logo and startup splash screen is the only thing changed. So use if desired.
denravonska added a commit that referenced this pull request May 25, 2018
Fixed
 - Fixes for displaying on high DPI displays, #517 (@skcin).
 - Re-enable unit tests, add unit test to Travis, #769, #808 (@TheCharlatan).
 - Fix empty string in sendalert2 (@tomasbrod).

Added
 - Neural Report RPC command, #1063 (@tomasbrod).
 - GUI wallet redign with new icons and purple native style (@skcin).

Changed
 - Switch to autotools and Depends from Bitcoin, #487 (@TheCharlatan).
 - Clean and update docs for new build system, remove outdated, #828 (@TheCharlatan).
 - Change estimated time to stake calculations to be more accurate, #1084 (@jamescowens).
 - Move logging to tinyformat, #1009 (@TheCharlatan).
 - Improve appcache performance, #734 (@denravonska).
 - Improve block index memory access performance, #679 (@denravonska).
 - NN fixes: clean logging, explain mag single response, move contract to ndata_nresp (@denravonska)
 - Updated translations:
    - Turkish, #771 (@confuest).
    - Chinese, #1012 (@linnaea).
 - RPC refactor: Cleaner locks, better error handling, move execute calls to straght rpc calls, #1024 (@Foggyx420).
 - Change locking primitives from Boost to STL, #1029 (@Foggyx420).

Removed
 - gridcoindiagnostic RPC call (@denravonska).
 - Galaza, #945 (@barton2526).
 - Assertion in SignSignature, #998 (@TheCharlatan).
 - Upgrade menu, #1094 (@jamescowens).
 - Acid test functions, #871 (@tomasbrod).
 - Qt4 support, #801 (@denravonska).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants