-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we have a top-level getter for cron similar to agent_label? #85
Comments
Hi @maxime-michel , as far I get it - you worrying about the pipeline configuration? So the Please check the custom pipeline example here to get some references in |
Hi @sparshev, Thanks for your answer. I am already working with a nested MPL pipeline, which I defined here: https://github.com/magnolia-cms/test-mpl-nested-library/blob/master/vars/NestedPipeline.groovy And while I can successfully configure MPL modules or individual stages (such as the Maven version used for the build shown in the example), my problem is that
Using Whereas it would work with The only way to support my use case would be that |
So, I think what you need - is to just use the configuration, because you know - modifying of the core MPL for each small parameter is quite bad way to manage the configuration. The For anything else I would recommend to use |
Thank you! That's perfectly acceptable for me, I just didn't quite see how to pull this out. I'll close this issue since the API you have in mind has little to do with what's been described here, OK? |
Ok, created a new ticket to implement the discussed interface. |
In our setup, some pipelines require a custom cron:
We already have a setup in which no cron is defined by default, and some project pipelines can override that. However, I would like to replicate this with MPL, because MPL brings a lot more flexibility than the templates we are currently working with.
Do I get this right that because that property is top-level such as
agent_label
, then a getter would be needed inMPLManager
? What are you thoughts on adding it?The text was updated successfully, but these errors were encountered: