Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors in server create cmd is not handled #88

Open
nvthongswansea opened this issue Nov 23, 2020 · 1 comment
Open

Errors in server create cmd is not handled #88

nvthongswansea opened this issue Nov 23, 2020 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@nvthongswansea
Copy link
Member

nvthongswansea commented Nov 23, 2020 •
edited
Loading

The error in this line L159 should be handled. And it is better, if the command can be rollbacked when there is an error returned. E.g. if linking a server and a storage fails, the server and the storage should be removed.
@nvthongswansea nvthongswansea added bug Something isn't working enhancement New feature or request labels Nov 23, 2020
@bkircher
Copy link
Contributor

bkircher commented Dec 1, 2020

E.g. if linking a server and a storage fails, the server and the storage should be removed.

Yep. Actually if you take a look closely at how the panel does this, you see POST /batch that will do exactly this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bkircher @nvthongswansea