-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
H5 Gridstack.js completely useless in safari #1540
Comments
will take me a while to try this on a mac as I'm on windows... |
Yeah, but it seems to get more importance to support Safari cause Apple is selling a lot of computers atm 👍🏿 |
You can try out Browserstack (https://www.browserstack.com/) |
JavaScript Console Error
|
@shmolf sounds like you are mixing html5 and jquery-ui there... I don't think that pertains to the site demos but I have not looked on safari yet. |
Ack! You're probably right. I'll try changing my assets, and let you know the result. |
I was using the following CDN URL This was referenced by the JS Fiddle example. Nothing else is loaded, other than CSS. |
We may independently use Jquery UI, but not for Gridstack. Does Gridstack check if Jquery UI is globally available, then references if so? |
please file a separate bug with reproduceable example. And no we don't reference JQ ui if it's available...onlyif our JQ plugin is used. |
I have same issue in safari, when i drag a grid element. I'm using latest release build: [Error] ReferenceError: Can't find variable: DragEvent |
for now you will need to use the jquery version |
* partial fix for gridstack#1540 * DragEvent is not defined on Safari (regular MouseEvent + dataTransfer field) * fixed initEvent() to clone the original event instead which simplifies and gets rid of runtime error msg more todo: dragstart now called, but not dragging. resizing works.
I spent a lot of time over the break and think I have a fix for Safari (and also better behavior for Chrome). Help or Donations would be appreciated.. |
I will definetly donate as soon as it will work on Safari and there will be the engine fix for swapping grid items instead of pushing them down...#149 |
* fix gridstack#1540 * according to spec (and required by Safari) the drag image has to be visible in the browser (in dom and not hidden) so make it a 1px div
* fix gridstack#1540 * DragEvent is not defined on Safari (regular MouseEvent + dataTransfer field) so fixed initEvent() to not use `instanceof DragEvent` but copy fields * according to spec (and required by Safari) the drag image has to be visible in the browser (in dom and not hidden) so make it a 1px div (this also helps chrome not showing a no-drop target cursor on Mac) * more DD code cleanup
* fix gridstack#1540 * DragEvent is not defined on Safari (regular MouseEvent + dataTransfer field) so fixed initEvent() to not use `instanceof DragEvent` but copy fields * according to spec (and required by Safari) the drag image has to be visible in the browser (in dom and not hidden) so make it a 1px div (this also helps chrome not showing a no-drop target cursor on Mac) * more DD code cleanup
fixed in upcoming 3.1.3 |
Subject of the issue
Gridstack.js completely useless in safari.
Your environment
Steps to reproduce
Just visit libary homepage and try to use examples.
Expected behavior
Tiles should be draggable
Actual behavior
No dragging ability...
The text was updated successfully, but these errors were encountered: