H5 safari drag fix #1549
Merged
H5 safari drag fix #1549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix gridstack#1540 * DragEvent is not defined on Safari (regular MouseEvent + dataTransfer field) so fixed initEvent() to not use `instanceof DragEvent` but copy fields * according to spec (and required by Safari) the drag image has to be visible in the browser (in dom and not hidden) so make it a 1px div (this also helps chrome not showing a no-drop target cursor on Mac) * more DD code cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
so fixed initEvent() to not use
instanceof DragEventbut copy fieldsthe browser (in dom and not hidden) so make it a 1px div
(this also helps chrome not showing a no-drop target cursor on Mac)
Checklist
yarn test)