Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compare.py] Exclude certain meta-data from comparison #135

Open
chovyy opened this issue Feb 13, 2018 · 4 comments
Open

[compare.py] Exclude certain meta-data from comparison #135

chovyy opened this issue Feb 13, 2018 · 4 comments

Comments

@chovyy
Copy link
Contributor

chovyy commented Feb 13, 2018

It would be nice if the comparison tool has an option to configure which meta-data is included or excluded for comparison.

Background: The new FortrantTestGenerator (FTG) frontend always stores the memory address of a variable in a meta-data field called loc. This is done, because sometimes when working with FTG it is necessary to identify pointers that refer to the same variable. When comparing the results of multiple runs of the same program, those value are obviously different, but shall not count as deviation. My current workaround is to remove this information before using compare.py.

There would be several solutions:

  • In general, only compare the standard meta-data (starting with __)
  • Add option to include (additional) meta-data fields
  • Add option to exclude meta-data fields
  • Either by naming concrete fields or by regular expression
  • ...
@havogt
Copy link
Collaborator

havogt commented Feb 16, 2018

I would go with "option to exclude meta-data fields". Probably this does not have priority for us, so probably you or someone else from the FTG users would have to implement it.

@chovyy
Copy link
Contributor Author

chovyy commented Feb 16, 2018

I will see if I can implement it once it's getting too annoying for me.

@chovyy
Copy link
Contributor Author

chovyy commented Feb 17, 2018

To keep it consistent, I will make it the same way as the savepoint filter, that is by default all, but with option to include(!) only those matching a regular expression. Okay?

@clementval
Copy link
Collaborator

@chovyy sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants