Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the boolean expression directly #8

Closed
suzil opened this issue Aug 5, 2017 · 2 comments
Closed

Return the boolean expression directly #8

suzil opened this issue Aug 5, 2017 · 2 comments

Comments

@suzil
Copy link
Contributor

suzil commented Aug 5, 2017

Statements like this one in PatternFinding.py

if parent == -1:
            return False
        else:
            return True

Should be rewritten to the equivalent, but simpler

return not (parent == -1)
@debugduck
Copy link
Contributor

I can take this one too, if it's still available!

@suzil
Copy link
Contributor Author

suzil commented Aug 8, 2017

@debugduck Go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants