Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CIViCpy Python >=3.5 compatible #91

Merged
merged 4 commits into from
Jun 19, 2020
Merged

Make CIViCpy Python >=3.5 compatible #91

merged 4 commits into from
Jun 19, 2020

Conversation

susannasiebert
Copy link
Collaborator

Closes #56

@ahwagner
Copy link
Member

ahwagner commented Jun 1, 2020

It looks like there are build errors for 3.5 that will need to be resolved before we can merge.

@susannasiebert susannasiebert linked an issue Jun 1, 2020 that may be closed by this pull request
Consider support for all active versions of Python 3 #56
Closed
@susannasiebert
Copy link
Collaborator Author

The travis-ci errors were related to pysam-developers/pysam#260 but were resolved by adding a pip install --upgrade pip before installing civicpy.

ahwagner
ahwagner previously approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@ahwagner ahwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. You annihilated those f-strings.

@susannasiebert susannasiebert changed the base branch from tests to master June 19, 2020 13:52
@susannasiebert susannasiebert dismissed ahwagner’s stale review June 19, 2020 13:52

The base branch was changed.

@susannasiebert susannasiebert merged commit a3d5da9 into master Jun 19, 2020
@susannasiebert susannasiebert deleted the python branch June 19, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahwagner ahwagner ahwagner left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider support for all active versions of Python 3
2 participants
@susannasiebert @ahwagner