Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Min and average #133

Merged
merged 4 commits into from Jan 12, 2020
Merged

Min and average #133

merged 4 commits into from Jan 12, 2020

Conversation

yang-yangfeng
Copy link
Contributor

also calculate pvalue using min value seen in samples with variant in addition to using the mean value (usually will be trivial/the same)

@coveralls
Copy link

coveralls commented Jan 10, 2020 •
edited

Coverage Status

Coverage remained the same at 90.677% when pulling c800cc8 on min_and_average into 7b80c9c on master.

kcotto
kcotto approved these changes Jan 11, 2020
View reviewed changes
Copy link
Contributor

@kcotto kcotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the script look good, I just added argparse back in. I also updated the docs a little more.

@kcotto kcotto merged commit a4c03ad into master Jan 12, 2020
@kcotto kcotto deleted the min_and_average branch January 12, 2020 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcotto kcotto kcotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yang-yangfeng @coveralls @kcotto