Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

METHOD_NAME should be const instead of var #21

Closed
GoogleCodeExporter opened this issue Jun 20, 2015 · 1 comment
Closed

METHOD_NAME should be const instead of var #21

GoogleCodeExporter opened this issue Jun 20, 2015 · 1 comment

Comments

@GoogleCodeExporter
Copy link

There are 68 occurrences of METHOD_NAME as a public static var, and 45
occurrences of METHOD_NAME as a public static const. Seems to me that they
should all be public static const.

Here are the cases where they are var instead of const:

commands\admin\GetAllocation.as(20):
public static var METHOD_NAME:String = 'admin.getAllocation';
commands\admin\GetAppProperties.as(22):
public static var METHOD_NAME:String = 'admin.getAppProperties';
commands\admin\GetMetrics.as(22):
public static var METHOD_NAME:String = 'admin.getMetrics';
commands\admin\GetRestrictionInfo.as(17):
public static var METHOD_NAME:String = 'admin.getRestrictionInfo';
commands\admin\SetAppProperties.as(17):
public static var METHOD_NAME:String = 'admin.setAppProperties';
commands\auth\CreateToken.as(20):
public static var METHOD_NAME:String = 'auth.createToken';
commands\auth\ExpireSession.as(20):
public static var METHOD_NAME:String = 'auth.expireSession';
commands\auth\GetSession.as(22):
public static var METHOD_NAME:String = 'auth.getSession';
commands\auth\PromoteSession.as(20):
public static var METHOD_NAME:String = 'auth.promoteSession';
commands\auth\RevokeAuthorization.as(20):
public static var METHOD_NAME:String = 'auth.revokeAuthorization';
commands\batch\BatchRun.as(26):
public static var METHOD_NAME:String = 'batch.run';
commands\connect\GetUnconnectedFriendsCount.as(21):
public static var METHOD_NAME:String = 'connect.getUnconnectedFriendsCount';
commands\connect\RegisterUsers.as(23):
public static var METHOD_NAME:String = 'connect.registerUsers';
commands\connect\UnregisterUsers.as(22):
public static var METHOD_NAME:String = 'connect.unregisterUsers';
commands\data\CreateObjectType.as(23):
public static var METHOD_NAME:String = 'data.createObjectType';
commands\data\DefineObjectProperty.as(23):
public static var METHOD_NAME:String = 'data.defineObjectProperty';
commands\data\DropObjectType.as(22):
public static var METHOD_NAME:String = 'data.dropObjectType';
commands\data\GetAssociationDefinition.as(20):
public static var METHOD_NAME:String = 'data.getAssociationDefinition';
commands\data\GetCookies.as(22):
public static var METHOD_NAME:String = 'data.getCookies';
commands\data\GetUserPreference.as(21):
public static var METHOD_NAME:String = 'data.getUserPreference';
commands\data\GetUserPreferences.as(18):
public static var METHOD_NAME:String = 'data.getUserPreferences';
commands\data\RenameObjectProperty.as(24):
public static var METHOD_NAME:String = 'data.renameObjectProperty';
commands\data\RenameObjectType.as(23):
public static var METHOD_NAME:String = 'data.renameObjectType';
commands\data\SetCookie.as(23):
public static var METHOD_NAME:String = 'data.setCookie';
commands\data\SetUserPreference.as(21):
public static var METHOD_NAME:String = 'data.setUserPreference';
commands\data\SetUserPreferences.as(23):
public static var METHOD_NAME:String = 'data.setUserPreferences';
commands\data\UndefineObjectProperty.as(24):
public static var METHOD_NAME:String = 'data.undefineObjectProperty';
commands\events\CancelEvent.as(20):
public static var METHOD_NAME:String = 'events.cancel';
commands\events\CreateEvent.as(23):
public static var METHOD_NAME:String = 'events.create';
commands\events\EditEvent.as(23):
public static var METHOD_NAME:String = 'events.edit';
commands\events\GetEvents.as(21):
public static var METHOD_NAME:String = 'events.get';
commands\events\GetMembers.as(21):
public static var METHOD_NAME:String = 'events.getMembers';
commands\events\RSVP.as(23):
public static var METHOD_NAME:String = 'events.rsvp';
commands\feed\PublishTemplatizedAction.as(22):
public static var METHOD_NAME:String = 'feed.publishTemplatizedAction';
commands\fql\FqlQuery.as(20):
public static var METHOD_NAME:String = 'fql.query';
commands\friends\AreFriends.as(24):
public static var METHOD_NAME:String = 'friends.areFriends';
commands\friends\GetAppUsers.as(22):
public static var METHOD_NAME:String = 'friends.getAppUsers';
commands\friends\GetFriends.as(20):
public static var METHOD_NAME:String = 'friends.get';
commands\friends\GetLists.as(20):
public static var METHOD_NAME:String = 'friends.getLists';
commands\groups\GetGroupMembers.as(23):
public static var METHOD_NAME:String = 'groups.getMembers';
commands\groups\GetGroups.as(24):
public static var METHOD_NAME:String = 'groups.get';
commands\links\PostLink.as(20):
public static var METHOD_NAME:String = 'links.post';
commands\livemessage\SendLiveMessage.as(23):
public static var METHOD_NAME:String = 'liveMessage.send';
commands\notifications\GetNotifications.as(20):
public static var METHOD_NAME:String = 'notifications.get';
commands\notifications\SendEmail.as(22):
public static var METHOD_NAME:String = 'notifications.sendEmail';
commands\notifications\SendNotification.as(22):
public static var METHOD_NAME:String = 'notifications.send';
commands\pages\GetPageInfo.as(25):
public static var METHOD_NAME:String = 'pages.getInfo';
commands\pages\IsAdmin.as(23):
public static var METHOD_NAME:String = 'pages.isAdmin';
commands\pages\IsAppAdded.as(21):
public static var METHOD_NAME:String = 'pages.isAppAdded';
commands\pages\IsFan.as(23):
public static var METHOD_NAME:String = 'pages.isFan';
commands\photos\AddTag.as(21):
public static var METHOD_NAME:String = 'photos.addTag';
commands\photos\CreateAlbum.as(21):
public static var METHOD_NAME:String = 'photos.createAlbum';
commands\photos\GetAlbums.as(25):
public static var METHOD_NAME:String = 'photos.getAlbums';
commands\photos\GetPhotos.as(25):
public static var METHOD_NAME:String = 'photos.get';
commands\photos\GetTags.as(26):
public static var METHOD_NAME:String = 'photos.getTags';
commands\photos\UploadPhoto.as(17):
public static var METHOD_NAME:String = 'photos.upload';
commands\profile\GetFBML.as(16):
public static var METHOD_NAME:String = 'profile.getFBML';
commands\profile\GetInfoOptions.as(16):
public static var METHOD_NAME:String = 'profile.getInfoOptions';
commands\profile\ProfileGetInfo.as(16):
public static var METHOD_NAME:String = 'profile.getInfo';
commands\profile\SetFBML.as(16):
public static var METHOD_NAME:String = 'profile.setFBML';
commands\profile\SetInfo.as(24):
public static var METHOD_NAME:String = 'profile.setInfo';
commands\profile\SetInfoOptions.as(20):
public static var METHOD_NAME:String = 'profile.setInfoOptions';
commands\users\GetInfo.as(17):
public static var METHOD_NAME:String = 'users.getInfo';
commands\users\GetLoggedInUser.as(17):
public static var METHOD_NAME:String = 'users.getLoggedInUser';
commands\users\GetStandardInfo.as(22):
public static var METHOD_NAME:String = 'users.getStandardInfo';
commands\users\HasAppPermission.as(16):
public static var METHOD_NAME:String = 'users.hasAppPermission';
commands\users\IsAppUser.as(21):
public static var METHOD_NAME:String = 'users.isAppUser';
commands\users\SetStatus.as(21):
public static var METHOD_NAME:String = 'users.setStatus';
Found 68 occurrence(s) in 68 file(s)

Original issue reported on code.google.com by fxlch...@gmail.com on 1 Apr 2009 at 4:48

@GoogleCodeExporter
Copy link
Author

Original comment by wgorgic...@gmail.com on 30 Jul 2009 at 8:47

  • Changed state: Verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant