-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working for Eclipse/Tycho project #5
Comments
I'm very sorry that you are having problems. I would be glad if you help me eliminate them. and you will see the full log. Please send it to me. Unfortunately, I have no experience with Eclipse/Tycho projects. And I debugged my plugin on projects - Quarkus / Spring-Boot-2.1.x. But I am ready to fix all the problems found |
Selecting build node "org.eclipse.ajdt" shows a completely empty log in the right panel. |
If you have time, please download the version with additional logs 233.24.1 https://plugins.jetbrains.com/plugin/22370-gmaven/versions/beta . And try again. There must be a stack trace (See idea logs Help->Show log in editor or there may be a pop-up notification with an error). Send it to me. Because I can't reproduce your problem locally. |
Are you saying, you can successfully import the project into IDEA with your plugin and build it, both from the Maven panel and - more importantly - from IDEA with |
|
Please try 233.24.2 version from https://plugins.jetbrains.com/plugin/22370-gmaven/versions/beta |
Probably AspectJ plugin resolve it problem https://plugins.jetbrains.com/plugin/4679-aspectj |
The *.aj files are indeed AspectJ source code ones. I am the maintainer of AspectJ and therefore work a lot with AspectJ projects. AJDT is the Eclipse IDE integration for AspectJ. But my own favourite IDE is IntelliJ IDEA, i.e. I am in the weird situation of working on Eclipse plugins in IDEA to avoid having to work with Eclipse. In Maven, the AspectJ Maven Plugin takes care of compiling the aspects and weaving them into other code. IDEA recognises AJ Maven and imports Maven projects, correctly adding an AspectJ facet to each corresponding module. I am going to give your new beta a spin, if my day-time work allows it, and then report back. |
After updating to beta 2, I see:
|
OK, I am one step further. I had to deactivate plugin https://plugins.jetbrains.com/plugin/16761-eclipse-pde-partial, which helped me compile the project with the regular Maven plugin. It seems to collide with GMaven. Re-importing the project with profile
|
please enable also profile "intelliji" or replace compile to package in imports args. But the "package" phase looks very redundant |
Oh yes, long ago I added that profile as a workaround for the fact that the modules
actually do not compile anything, but simply re-package sources and binaries into new JARs, adding Eclipse-related OSGi stuff to the manifests. I was just thinking about moving all those plugin executions to |
OK, Do you feel like integrating Aspectj Maven into GMaven? |
Actually, when closing an reopening the project, it did not remember the profile settings and reimported with Worse, the profile settings for the IDE build were also forgotten, I had to re-select the same profiles in the GMaven tab on the right. |
Yes, this is a price for simplicity, so that you can get all the information about the project from Maven (content roots and dependencies). The IDEA Maven plugin uses a different approach, where code is duplicated from tycho-*-plugins and etc. But this leads, as practice shows, to many errors. I believe that there should be one data source - Maven. Excessive customization will lead to errors.
Thanks for the feedback. I'll try to study this aspect in the near future. How did you work with your project before if the Maven bundled plugin does not recognize either the dependencies and the content roots? |
strangely it doesn't play locally. I'll take a look |
Another problem is that whenever I close and reopen the project, I get this error:
|
Some good news in between - sorry for posting a lot here: Now suddenly, some modules have AspectJ facets. |
A combination of PDE Partial plugin, OSGi plugin and the |
Worse than this, the error also appears when opening other projects that do not use GMaven but the normal Maven plugin. |
Oh sorry... I use Linux so there is no way to test on Windows. This is where there are so many problems. |
Update installed. The problem from #5 (comment) still exists. I see that the OSGi dependencies are resolved to libraries in the project configuration by GMaven, but not listed as dependencies in the relevant modules. I am not sure if that is important, so I am mentioning it, just in case. But the library is already part of the project, just not assigned as a plugin dependency. |
Invalidating the caches did not help. After the restart, the class names are still red, even after a successful recompile. The GMaven tab forgot to remember the last state, i.e. opened list entries for profiles and modules (both closed again). It also forgot the selected profiles. I re-selected them, re-imported the project and issued a project rebuild. The rebuild purged the compiled aspects again, so I re-imported a second time. Next, I tried a normal IDEA build instead of a full rebuild. That build is slow, but successful, repeating what Maven just did. But to no avail, the classes are still unresolved. Next, I will purge the |
For now, removing the IDEA project folder and starting from scratch helped. I will not work on that project much in the next few weeks, because I just finished an AspectJ update yesterday with the old setup, but I will definitely continue testing GMaven for this project and see how stable it is when changing files, closing and re-opening the project and IDEA etc. |
Thank you for taking the time to leave a feedback. It is very important for me to make gmaven better |
As both an OSS user and developer, I know how important user feedback is. Your plugin has potential, but I did not want to test it in simpler projects which are dealt with nicely by the built-in Maven plugin, but on another one inadequately handled by IDEA out of the box. This is where the main benefit lies for me personally. |
I completely agree with you that it is necessary to test on those projects on which Maven bundled plugin not work. I know one such project https://github.com/dbeaver/dbeaver. |
Clone https://github.com/eclipse-aspectj/ajdt and import the project into IDEA 2023.3.6 Ultimate. You will only see this error in the "Build" tab:
On reload, the IDEA log file only says:
This was my first try with the plugin, because you asked me to try it via your friend's LinkedIn account. This experience is not very encouraging.
The text was updated successfully, but these errors were encountered: