-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nodes that come from f-string parents lack token information #6
Comments
@LiraNuna thanks for keeping this issue open and for the explanations in #4 about what's going on 👍 The original Python issue 29051 was split into two - and the first one https://bugs.python.org/issue30465 "FormattedValue expressions have wrong lineno and col_offset information" is now resolved. Does this mean that this bug can be solved properly now? For reference, I'm about to wire in a work around to fix this here: jamescooke/flake8-aaa#101 - probably something to prevent the error being raised when the linter tries to access the token information on an f-string. |
It's been a while and I have to admit I forgot most of the details. |
I'm not really up for a PR right now, but here's an idea for an algorithm:
|
The new |
Because of https://bugs.python.org/issue29051, a temporary solution (See #4) was placed to avoid exceptions.
This issue is to track this workaround's life time so it could be fixed once the above python issue is fixed.
The text was updated successfully, but these errors were encountered: