Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for dead pythons #67

Closed
wants to merge 1 commit into from
Closed

Drop support for dead pythons #67

wants to merge 1 commit into from

Conversation

WhyNotHugo
Copy link

Drop support for Pythons than reached their end of life and are no longer supported.

Drop support for Pythons than reached their end of life and are no
longer supported.
@dsagal
Copy link
Member

dsagal commented Apr 7, 2021

Sorry but I still need support for 2.7! :)

@alexmojaki
Copy link
Contributor

Is there a specific reason to do this? Do you want to make other changes to the codebase afterwards?

Here are some libraries which use asttokens and support 2.7:

@WhyNotHugo
Copy link
Author

WhyNotHugo commented Apr 7, 2021

I'm mostly looking to trim me dependency tree by dropping things like six which are only required for compatibility with unsupported versions of Python.

But no, no follow up PR intended.

@WhyNotHugo
Copy link
Author

Can't those downstream dependees simply depend on an older version of this library, much like they depend on an older Python?

@alexmojaki
Copy link
Contributor

I'm mostly looking to trim me dependency tree by dropping things like six which are only required for compatibility with unsupported versions of Python.

  1. I'm curious, where are you using asttokens?
  2. Is asttokens your only dependency that uses six? six is quite popular.
  3. Would dropping six from your dependency tree really be helpful?
  4. Removing six from the dependencies of asttokens looks like it should be quite easy. Only a few symbols are used, it'd be easy to 'implement' them.

Can't those downstream dependees simply depend on an older version of this library

No, I want them to benefit from future updates to this library.

much like they depend on an older Python?

They support 2.7, they don't depend on it. They also support 3.9.

@WhyNotHugo
Copy link
Author

Oh, I see. I guess this PR doesn't make sense in that case.

Again, I've no pressing need to trim six immediately, it just bothers me to have dependencies installed only to support software that's long past reached it's end of life.

Sorry for the noise!

@WhyNotHugo WhyNotHugo closed this Apr 7, 2021
@alexmojaki alexmojaki mentioned this pull request Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants