Skip to content

Commit

Permalink
don't fail to ask for a password if there is no TTY
Browse files Browse the repository at this point in the history
When running grml-debootrap over ssh like
  ssh root@grml grml-debootstrap ...
the password promt for the root user would fail, as you cannot stty
without a tty. The user should actually have called
  ssh -t root@grml grml-debootstrap ...
which would have allocated a TTY and all would have worked.

Display a warning to the user and fall back to displaying the entered
password when he continues to use grml-debootstrap w/o a TTY.

Closes: issue1200
  • Loading branch information
evgeni authored and mika committed Feb 4, 2013
1 parent 488643a commit a93156c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
4 changes: 2 additions & 2 deletions chroot-script
Expand Up @@ -55,9 +55,9 @@ stage() {
askpass() {
# read -s emulation for dash. result is in $resp.
set -o noglob
stty -echo
[ -t 0 ] && stty -echo
read resp
stty echo
[ -t 0 ] && stty echo
set +o noglob
}
# }}}
Expand Down
6 changes: 6 additions & 0 deletions grml-debootstrap
Expand Up @@ -730,6 +730,12 @@ else # if not running automatic installation display configuration and prompt fo
[ -n "$VMSIZE" ] && echo " Using Virtual Disk file with size of ${VMSIZE}."
fi

if [ ! -t 0 -a -z "$ROOTPASSWORD" -a -z "$NOPASSWORD" ] ; then
echo
echo " You do not have a TTY allocated, your password will be shown in"
echo " plaintext on the terminal! If you are using SSH, try its -t option!"
fi

echo
echo " Important! Continuing will delete all data from ${TARGET}!"

Expand Down

0 comments on commit a93156c

Please sign in to comment.