consistently use ESP label for the EFI system partition #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change from EFI to ESP for arm64 builds
|
Wasn't aware of this, nice catch, thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change from EFI to ESP for arm64 builds
Use of ESP is more popular.
If we'd use the long label it would be "EFI system partition" but since we use the short label it should be ESP.
Why bother? Because then later
PARTLABELcan be used in/etc/fstab.https://wiki.archlinux.org/title/fstab#GPT_partition_labels
Any label with spaces is more error-prone.
I haven't found any convention for partition labels but consistency makes sense.