implement clean_chroot, #267
Conversation
avoid host environment variables such as TMP to leak into the chroot fixes grml#232
|
Some optional explanation why I made certain changes the way I made them. If we use
Even A potential alternative that I personally would use is
Which environment variables are passed into the chroot is currently hardcoded. I didn't think it is important to be able to configure that. If somebody needs to configure that, I guess they can create a feature request and/or send a pull request. The xtrace ( I was also wondering if it was better to use a similar mechanism to the one you're using for |
|
Resolved merge conflict. |
|
Ping? |
|
Good now? |
|
Ping? |
| @@ -1766,7 +1766,7 @@ clean_chroot() { | |||
| local chroot_command=("${@:2}") | |||
|
|
|||
| # Run chroot, then env -i with the specified environment variables inside the chroot | |||
| /usr/sbin/chroot "$chroot_dir" /usr/bin/env -i "${env_vars[@]}" "${chroot_command[@]}" | |||
| chroot "$chroot_dir" /usr/bin/env -i "${env_vars[@]}" "${chroot_command[@]}" | |||
There was a problem hiding this comment.
I think we even don't need to hardcode the /usr/bin/env full path?
| einfo "End of debootstrap.log" | ||
| fi | ||
| ## Check if "bailout" function is available. | ||
| ## This is not the case in chroot-script. |
There was a problem hiding this comment.
hm, I don't understand why this change ends up in this clean_chroot feature/commit, is the github web UI showing something unexpected? o_
| @@ -26,7 +25,6 @@ set -e | |||
| set -E | |||
| set -o pipefail | |||
| trap "error_handler" ERR | |||
| export -f "error_handler" | |||
There was a problem hiding this comment.
is removing the export of the error_handler from grml-debootstrap and addition of it to chroot script related to the environment cleanup, right?
There was a problem hiding this comment.
Ah, you mentioned this in a comment as I just noticed:
If we use env -i then we can no longer export shell functions. So export -f "error_handler" had to be removed.
We should squash all the relevant commits into one single commit and provide that useful information you collected into the commit message :)
Do you want me to give this a try or would you prefer to try on your own?
avoid host environment variables such as TMP to leak into the chroot
fixes #232