Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanchit comments #47

Open
atherdon opened this issue Oct 17, 2018 · 6 comments
Open

Sanchit comments #47

atherdon opened this issue Oct 17, 2018 · 6 comments

Comments

@atherdon
Copy link
Member

GroceriStar/react-only-intern-23#70 (comment)

@atherdon
Copy link
Member Author

@sanchit94 if you wish - we can discuss here a tasks, that should be done by other React interns, in order to make code of this repository more clear...

@sanchit94
Copy link
Collaborator

Hey Arthur, I think a few things can be done to make this repo's code better:

  1. The function checks for a new task every 15 mins, that should be changed to check every minute. This would be good practice.
  2. Responsiveness of the calender component.
  3. Also, if someone can write this code with better algo, he/she must be encouraged.

@atherdon
Copy link
Member Author

atherdon commented Oct 25, 2018 via email

@sanchit94
Copy link
Collaborator

Yeah react-final-form code is really great, I think it should be used for the form part.

@sanchit94
Copy link
Collaborator

I want to continue with this project on react but due to shortage of time I am not able to get my head into it. Additionally I am working on project in Angular so I have much better perspective of these frameworks now. However, once I am done with the Angular project I would love to contribute to this project as I have not written JAVASCRIPT for a while!

@atherdon
Copy link
Member Author

cool! this is a perfect news! we actually re-forming our powers and starting to work on main GS React frontend

@atherdon atherdon added this to the Working Calendar milestone Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants