Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link #63

Closed
atherdon opened this issue Oct 31, 2018 · 4 comments
Closed

Link #63

atherdon opened this issue Oct 31, 2018 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@atherdon
Copy link
Member

https://github.com/GroceriStar/calendar/blob/master/src/components/Calendar/Meal.js#L26
https://github.com/GroceriStar/calendar/blob/master/src/components/Modals/ModalWork.js#L87-L91
@atherdon atherdon mentioned this issue Oct 31, 2018
Closed
@atherdon atherdon added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 9, 2018
@atherdon
Copy link
Member Author

atherdon commented Nov 9, 2018

@GuiFSs this is a small task too. you can see it duplicated at groceristar-frontend project too

@GuiFSs
Copy link
Collaborator

GuiFSs commented Nov 9, 2018

@atherdon can you explain me how do you want it to be? because i don't see a good way to move links to another component

@atherdon
Copy link
Member Author

atherdon commented Nov 9, 2018

hmm, looks like we solve it :)
Sorry for taking your time on it.

Main idea was to replace tag with component from react-dom

@atherdon
Copy link
Member Author

atherdon commented Nov 9, 2018

closing it

@atherdon atherdon closed this as completed Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atherdon @GuiFSs