Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks List #71

Open
2 of 3 tasks
atherdon opened this issue Nov 4, 2018 · 20 comments
Open
2 of 3 tasks

Tasks List #71

atherdon opened this issue Nov 4, 2018 · 20 comments
Assignees

Comments

@atherdon
Copy link
Member

atherdon commented Nov 4, 2018


  • Schedule render component have filename Schedule
    Easy thing. we just need to rename file and check places, when it was connected and update pathnames there too.

  • Add Meal Form
    More details upon request.

Looks like Sanchit move a few not necessary components, like AddMeal.js
as you can see - that file have inside import of MealPlan form - that we don't have in our project. Also, AddMeal component not called anywhere (I assume).
I want you to clean up our project(Note: I didn't tell you delete this component - try to figure out what did i mean)

@GuiFSs
Copy link
Collaborator

GuiFSs commented Nov 7, 2018

i can do the second and the third task, but for the third one, i'll need more information about what should be in MealForm component

@atherdon
Copy link
Member Author

atherdon commented Nov 7, 2018

Ok, let's start from second task

@atherdon
Copy link
Member Author

atherdon commented Nov 7, 2018

Story:
Previosly, most part of this funcitonality was done by Sanchit - while he learned how to code at React.
At some point, we decided to split code, that was made into a few chunks. My aim was to separate meal calendar and work on it as standalone module. it helps us to make it clean, try different approaches, etc.

AddMealForm is a file, that was used at Sanchit project. And we move it only for one reason - without this component - our project will be broken(because our previous project structure was not ideal, but ok).
Actually, at this stage of calendar module - we don't need this form. So main idea was to remove this component. But not just delete it and forget about it. You should be aware and check whole project. because if you just delete this file - it'll break the project - you should prevent it and clean up our code.

tell me if something is not clear @GuiFSs

@GuiFSs
Copy link
Collaborator

GuiFSs commented Nov 7, 2018

so, the file AddMealModal.js in the project will be in another module and should be deleted from this one, but i have to make sure that when i delete it, it won't break the project, but for what i saw, this file is not been used in any other component, so i think it won't be a problem

@atherdon
Copy link
Member Author

atherdon commented Nov 7, 2018

yes, you're right, but i'm not sure if it not used anywhere

@GuiFSs
Copy link
Collaborator

GuiFSs commented Nov 7, 2018

ok so, i was testing the "switch mode" button, and i found an error when we get a dish by week, should i open a issue and try to figure it out the problem? i think it's because the function getRandomWeek in WorkSchedule.js file

@atherdon
Copy link
Member Author

atherdon commented Nov 7, 2018

yes, please open an issue and explain it here. it'll help us in future

@atherdon
Copy link
Member Author

atherdon commented Nov 7, 2018

Please follow this link https://github.com/GroceriStar/calendar/invitations

@GuiFSs
Copy link
Collaborator

GuiFSs commented Nov 7, 2018

Please follow this link https://github.com/GroceriStar/calendar/invitations

sorry to ask, but what is this for?

@atherdon
Copy link
Member Author

atherdon commented Nov 7, 2018

you can read it by URL :) want to add you to collaborators, so i can assign tasks at this repo for you

@atherdon
Copy link
Member Author

atherdon commented Nov 9, 2018

@GuiFSs let's discuss here what else we can do at this project right now. Do you have any ideas?

@atherdon
Copy link
Member Author

atherdon commented Nov 9, 2018

i'm curious to see your ideas about how we can improve it

@GuiFSs
Copy link
Collaborator

GuiFSs commented Nov 9, 2018

ok, but first i would like to know more about the main function of calendar, i mean, correct me if i'm wrong, the objective of calendar is to show the users, suggestions about helthy meals, ingredients, etc, in a certain day and time, so the user can keep it organized and have a better diet

@atherdon
Copy link
Member Author

atherdon commented Nov 10, 2018

right now is more simple than you think. Maybe later we'll evolve it, but for now - main goal of this project is to give an ability to people see meal plans(i.e. meals/recipes) per days.
Nothing more nothing less. This repository is our sandbox. Where we testing different layouts, different components that we can use.

When we'll make the code of it clean - we'll be able to add this module to our projects.

@GuiFSs
Copy link
Collaborator

GuiFSs commented Nov 11, 2018

well, the only thing i can think now is to have a way of people share this meal plans, i think this is a good way bring more people to the site. But i don't know if this is too complex right now

@atherdon
Copy link
Member Author

yeah, i like your idea. will add it to our feature list. and yes - it's not a simple thing

@atherdon
Copy link
Member Author

@GuiFSs do you have other tasks?

@GuiFSs
Copy link
Collaborator

GuiFSs commented Nov 22, 2018

@atherdon actually i don't have

@atherdon
Copy link
Member Author

https://github.com/GroceriStar/react-shopping-list-template/issues/67
GroceriStar/react-shopping-list-template#66
please grab something from here - but notify what you'll take. we are with Vadim working on it too

@atherdon
Copy link
Member Author

@GuiFSs tell me if you need help with this task from that repo or if you busy at college - so i'll be able to assign it to someone else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants