Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile-grocy: php-fpm.conf sed 'listen' directives are outdated #37

Closed
jayaddison opened this issue Mar 23, 2020 · 0 comments · Fixed by #38
Closed

Dockerfile-grocy: php-fpm.conf sed 'listen' directives are outdated #37

jayaddison opened this issue Mar 23, 2020 · 0 comments · Fixed by #38

Comments

@jayaddison
Copy link
Contributor

tl;dr - some sed commands in Dockerfile-grocy are no-ops and can be removed.

Detailed Summary

Although the sed ... php-fpm.conf commands in Dockerfile-grocy succeed, they don't appear to be applying edits to /usr/local/etc/php-fpm.conf currently.

The listen directives may have been moved into different files in the image's filesystem (image ref: php:7.2-fpm-alpine).

Steps to check the contents of the base image:

# create and start a root shell in a container
$ buildah run $(buildah from php:7.2-fpm-alpine) sh -c "PS1='% ' sh"

# look for 'listen' directives in the base fpm conf file
% grep "listen\s*=" /usr/local/etc/php-fpm.conf

# perform the same search in the fpm conf include directory
% grep "listen\s*=" /usr/local/etc/php-fpm.d/*.conf
/usr/local/etc/php-fpm.d/www.conf:listen = 127.0.0.1:9000
/usr/local/etc/php-fpm.d/zz-docker.conf:listen = 9000

Cause (pending further investigation)

The php:7.2-fpm-alpine Dockerfile hasn't changed much between 7.2-alpha3 and the latest version.

It seems most likely that change(s) to the underlying Alpine filesystem (3.6 -> 3.11) and/or PHP release (7.2.0-alpha3 -> 7.2.29) may have changed between 3.6 and 3.11?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant