Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heroku][AWS] handler not working because of url param rewritten #13

Closed
ylecuyer opened this issue Sep 24, 2019 · 5 comments
Closed

[Heroku][AWS] handler not working because of url param rewritten #13

ylecuyer opened this issue Sep 24, 2019 · 5 comments

Comments

@ylecuyer
Copy link
Contributor

ylecuyer commented Sep 24, 2019

Hi, I tried to connect heroku to glip with the heroku deploy hooks addon but it is not working.

Heroku sends an URL param in the post body which overwrite the URL in the query.

Could we add an alias for the url param?

@ylecuyer
Copy link
Contributor Author

ylecuyer commented Oct 2, 2019

I checked with the proxy running locally and this error is only for the aws handler.
Looks like the aws api gateway is the cause of this error.

@grokify
Copy link
Owner

grokify commented Mar 23, 2020

The reason AWS doesn't work is that Lambda functions don't handle application/x-www-form-urlencoded requests provided by Heroku so the code needs to be modified for AWS.

Heroku now supports application/json webhooks so updating the Heroku handler to JSON will solve the issue for Heroku.

https://devcenter.heroku.com/articles/app-webhooks#receiving-webhooks

Heroku calls this version 3.

"version": "application/vnd.heroku+json; version=3"

I'll update / enhance to support the JSON webhook event format which should resolve this.

Wootric still uses a Ruby on Rails type webhook format so it needs to be supported for that: #15

@grokify grokify self-assigned this Mar 23, 2020
@grokify grokify changed the title [Heroku] handler not working because of url param rewritten [Heroku][AWS] handler not working because of url param rewritten Nov 5, 2021
@grokify
Copy link
Owner

grokify commented Nov 6, 2021

@grokify grokify added this to the v0.7.0 milestone Nov 8, 2021
@grokify
Copy link
Owner

grokify commented Nov 8, 2021

Implemented in a3b406c

As of this commit, url param has been renamed to outputURL param. There is no fallback but multiple instances of Chathooks can be run during the roll over.

@grokify
Copy link
Owner

grokify commented Nov 16, 2021

v0.7.0 Released.

@grokify grokify closed this as completed Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants