-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logical_range_filter: Make result_sets enumeration sharable #1346
logical_range_filter: Make result_sets enumeration sharable #1346
Conversation
@@ -43,6 +43,28 @@ def have_record? | |||
true | |||
end | |||
|
|||
protected | |||
def enumerate_result_sets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
each_result_set
is better for Ruby.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have renamed it.
@@ -43,6 +43,28 @@ def have_record? | |||
true | |||
end | |||
|
|||
protected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it needed?
Generally, protected
isn't used in Ruby.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, protected isn't used in Ruby.
I see. (I didn't know that.)
I have removed this method access modifier.
Remove a protected accessor
end | ||
each_result_set do |result_set| | ||
sort_result_set(result_set) | ||
return if @window && @context.current_limit.zero? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is @window &&
needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had added this just because originally @context.current_limit.zero?
was executed only when @window
.
However, even removing @window &&
, all logical_range_filter
tests were passed.
So I have removed this @window &&
.
logical_range_filter: Make result_sets enumeration sharable on
StreamShardExecutor