logical_range_filter: Make result_sets enumeration sharable #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
kou
reviewed
Mar 31, 2022
| @@ -43,6 +43,28 @@ def have_record? | |||
| true | |||
| end | |||
|
|
|||
| protected | |||
| def enumerate_result_sets | |||
There was a problem hiding this comment.
each_result_set is better for Ruby.
There was a problem hiding this comment.
I have renamed it.
| @@ -43,6 +43,28 @@ def have_record? | |||
| true | |||
| end | |||
|
|
|||
| protected | |||
There was a problem hiding this comment.
Why is it needed?
Generally, protected isn't used in Ruby.
There was a problem hiding this comment.
Generally, protected isn't used in Ruby.
I see. (I didn't know that.)
I have removed this method access modifier.
Remove a protected accessor
kou
reviewed
Mar 31, 2022
| end | ||
| each_result_set do |result_set| | ||
| sort_result_set(result_set) | ||
| return if @window && @context.current_limit.zero? |
There was a problem hiding this comment.
I had added this just because originally @context.current_limit.zero? was executed only when @window.
However, even removing @window &&, all logical_range_filter tests were passed.
So I have removed this @window &&.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logical_range_filter: Make result_sets enumeration sharable on
StreamShardExecutor