Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NormalizerNFKC: add unify_katakana_g_sounds option #1501

Merged
merged 12 commits into from
Feb 2, 2023
Merged

NormalizerNFKC: add unify_katakana_g_sounds option #1501

merged 12 commits into from
Feb 2, 2023

Conversation

HashidaTKS
Copy link
Contributor

@HashidaTKS HashidaTKS commented Feb 1, 2023 •
edited
Loading

When unify_katakana_g_sounds is specified, NormalizerNFKC* normalize characters as below.

グァ -> ガ
グィ -> ギ
グェ -> ゲ
グォ -> ゴ

Usage:

normalize \
  'NormalizerNFKC130("unify_katakana_g_sounds", true, \
                     "report_source_offset", true)' \
  "グァグィグェグォ" \
  WITH_CHECKS|WITH_TYPES

@HashidaTKS HashidaTKS changed the title NormalizerNFKC: add unify_katakana_g_sounds NormalizerNFKC: add unify_katakana_g_sounds option Feb 1, 2023
@HashidaTKS HashidaTKS mentioned this pull request Feb 2, 2023
Merged
@HashidaTKS HashidaTKS marked this pull request as ready for review February 2, 2023 03:17
kou
kou reviewed Feb 2, 2023
View reviewed changes
lib/normalizer.c Outdated Show resolved Hide resolved
test/command/suite/normalizers/nfkc100/unify_katakana_g_sounds.reject Outdated Show resolved Hide resolved
lib/normalizer.c Show resolved Hide resolved
@kou
Copy link
Member

kou commented Feb 2, 2023

Could you rebase on master and add a test for NormalizerNFKC150?

@HashidaTKS
Copy link
Contributor Author

Could you rebase on master and add a test for NormalizerNFKC150?

Added.

@HashidaTKS
Copy link
Contributor Author

@kou

Thank you for your comments.
I have addressed your comments.

@kou kou merged commit b16ba79 into master Feb 2, 2023
@kou kou deleted the add-unify_katakana_g_sounds branch February 2, 2023 07:41
@github-actions github-actions bot mentioned this pull request May 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HashidaTKS @kou