Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NormalizerNFKC: add unify_katakana_wo_sound option #1503

Merged
merged 9 commits into from
Feb 3, 2023
Merged

NormalizerNFKC: add unify_katakana_wo_sound option #1503

merged 9 commits into from
Feb 3, 2023

Conversation

HashidaTKS
Copy link
Contributor

@HashidaTKS HashidaTKS commented Feb 1, 2023 •
edited
Loading

When unify_katakana_wo_sound is specified, NormalizerNFKC* normalize characters as below.

ヲ -> オ

normalize \
  'NormalizerNFKC130("unify_katakana_wo_sound", true, \
                     "report_source_offset", true)' \
  "ヲ" \
  WITH_CHECKS|WITH_TYPES

@HashidaTKS HashidaTKS changed the title NormalizerNFKC: Add unify_katakana_wo_sounds option NormalizerNFKC: add unify_katakana_wo_sounds option Feb 1, 2023
@kou
Copy link
Member

kou commented Feb 2, 2023

Could you remove the last s from option name (unify_katakana_wo_sound) ?
Because this only processes one character.

@HashidaTKS
Copy link
Contributor Author

Could you remove the last s from option name (unify_katakana_wo_sound) ? Because this only processes one character.

Fixed.

@HashidaTKS HashidaTKS changed the title NormalizerNFKC: add unify_katakana_wo_sounds option NormalizerNFKC: add unify_katakana_wo_sound option Feb 2, 2023
@HashidaTKS HashidaTKS mentioned this pull request Feb 2, 2023
Merged
@HashidaTKS HashidaTKS marked this pull request as ready for review February 3, 2023 02:20
@HashidaTKS
Copy link
Contributor Author

@kou

Would you re-review this?

kou
kou reviewed Feb 3, 2023
View reviewed changes
lib/normalizer.c Outdated Show resolved Hide resolved
@kou kou merged commit f84cf01 into master Feb 3, 2023
@kou kou deleted the add-unify_katakana_wo_sounds branch February 3, 2023 02:28
@github-actions github-actions bot mentioned this pull request May 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HashidaTKS @kou