Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ros2 subscribe bug #73

Open
jsb04 opened this issue Feb 9, 2023 · 0 comments
Open

ros2 subscribe bug #73

jsb04 opened this issue Feb 9, 2023 · 0 comments

Comments

@jsb04
Copy link

jsb04 commented Feb 9, 2023

Hi,

I think there is a bug/mistake in the Ros2 branch; while ros2 topics are subscribed to I don't think mqtt topics are subscribed because the initialization of the bridges happens before the mqtt client is connected so the subscription message is never sent. See lines 74 to 80 of https://github.com/groove-x/mqtt_bridge/blob/ros2/mqtt_bridge/app.py:

    # configure bridges
    bridges = []
    for bridge_args in bridge_params:
        bridges.append(create_bridge(**bridge_args,ros_node=mqtt_node))

    # start MQTT loop
    mqtt_client.loop_start()

This can be fixed by moving the last 2 lines to above line 74. Am I missing something or does anyone else agree that this is a bug/issue?

@jsb04 jsb04 changed the title ros2 subscribe gug ros2 subscribe bug Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant