Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React to rate-limit being reached #87

Open
openjck opened this issue Jul 1, 2015 · 9 comments
Open

React to rate-limit being reached #87

openjck opened this issue Jul 1, 2015 · 9 comments
Labels
enhancement

Comments

@openjck
Copy link
Contributor

openjck commented Jul 1, 2015

When using OAUTH authentication, we are limited to 5,000 API calls per hour. We need to handle the case where the limit is reached.
@groovecoder
Copy link
Owner

Yes, big 👍 for this!

@darkwing
Copy link
Contributor

darkwing commented Jul 7, 2015

Great idea @openjck . We may want to investigate a way to request/purchase increased rate limits as something like this would definitely, definitely limit scale. We may need multiple accounts to work around it, or something.

Anywho, this is a great starting idea!

@groovecoder
Copy link
Owner

Are we making the API reuqests with an oauth2 key/secret? We already have an MDN GitHub application; we could use its client/secret to increase our rate limit from 60/hour to 5,000/hour.

@openjck openjck modified the milestone: MVQ Jul 8, 2015
@openjck openjck added bug and removed enhancement labels Jul 8, 2015
@Faeranne
Copy link
Contributor

Faeranne commented Jul 8, 2015

We are using an API token with the commenter, which should already give us the 5,000/hour on comments. Octonode, however, is not using the token.

@openjck
Copy link
Contributor Author

openjck commented Jul 10, 2015

We should still do this, but as it turns out, the rate-limit isn't the problem here. Comments fail to appear even when we are well below the limit. I'll open a separate issue for the real culprit.

@openjck openjck changed the title Hold comments until rate-limit has expired React to rate-limit being reached Jul 10, 2015
@openjck
Copy link
Contributor Author

openjck commented Jul 10, 2015

Opened #104 for the issue that actually prevented comments from appearing.

openjck added a commit to openjck/discord that referenced this issue Jul 10, 2015
@openjck
Use the OAUTH token with octonode
0b36519 
This will increase our rate-limit to 5,000 but will not fix the
commenting bug. [1]

[1] groovecoder#87 (comment)
@openjck openjck mentioned this issue Jul 10, 2015
Merged
@openjck
Copy link
Contributor Author

openjck commented Jul 10, 2015

limiter looks to be the best-supported node module for dealing with rate limits.

openjck added a commit to openjck/discord that referenced this issue Jul 10, 2015
@openjck
Use the OAUTH token with octonode
7f8f79b 
This will increase our rate-limit to 5,000 per hour but will not fix the
commenting bug. [1]

[1] groovecoder#87 (comment)
@openjck openjck mentioned this issue Jul 17, 2015
Closed
@openjck openjck removed this from the MVP #1 milestone Aug 22, 2015
@groovecoder
Copy link
Owner

I think this is fixed via #112?

@openjck
Copy link
Contributor Author

openjck commented Dec 31, 2015

Similar!

What we called a rate-limit in #104 was actually just an anti-spam system. Submitting too many comments too quickly triggered the system and caused some comments to be dropped. We fixed that with #131.

There's also a true API rate-limit of something like 5,000 requests per hour. This issue is about reacting when we reach that limit.

@openjck openjck added enhancement and removed bug labels Dec 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@darkwing @groovecoder @Faeranne @openjck