Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom trip banner can disappear after swipe down of trip details view #897

Open
Altonss opened this issue Dec 8, 2023 · 1 comment
Open
Labels
bug 🐞 A functional defect or unexpected behavior.

Comments

@Altonss
Copy link
Collaborator

Altonss commented Dec 8, 2023

Describe the bug
The bottom trip banner can disappear after swipe down of trip details view, leaving the screen with only a blank banner at the bottom, without a possibility to bring up the trip details again.

To Reproduce

  1. Click on a specific trip to show the detailed view.
  2. Swipe down the details to show the map.
  3. Repeat these swipes several times completely (reducing trip info to bottom banner).
  4. See error: sometimes the banner becomes blank, leaving no other possibility then to go back.

Expected behavior
Do not leave the bottom banner blank.

Screenshots
image

Versions (please complete the following information):

  • Transportr Version: 2.1.5 and 2.2.0 (preview)
  • Android Version: 13
@Altonss Altonss added the bug 🐞 A functional defect or unexpected behavior. label Dec 8, 2023
@newhinton
Copy link

The culprit is likely the handling of bottom-sheets. It also applies to the activity_map bottom sheet, aswell as the fragment_trip_detail bottom sheet.

In the TripDetailFragment, the bottomsheet can be closed by swiping down the topBar. When swiping down any other element, it collapses properly.

I think they are not meant to be used in this way. They have a behavior_hideable attribute, but if they are set to false, the bottom sheets dont resize and always take their full space, which is also unwanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 A functional defect or unexpected behavior.
Projects
None yet
Development

No branches or pull requests

2 participants