Improved finding of names for unnamed stops - #39 #43
Conversation
pantierra
changed the title
| @@ -314,7 +338,7 @@ def _build_stop(self, stop, stop_type): | |||
|
|
|||
| # Make sure name is not empty | |||
| if 'name' not in stop.tags: | |||
| stop.tags['name'] = Stop.NO_NAME | |||
| stop.tags['name'] = "[" + self.stop_no_name + "]" | |||
There was a problem hiding this comment.
Why use the square brackets here? When you don't search for stop names and there's stops without name, there will be square brackets in the name. Is that intentional?
There was a problem hiding this comment.
Yes, it is! Because I don't want to hit the nearest search if it was unsuccessful once. This is the same behaviour as before.
When creating the stops from the first query the ones without name get something like [No name], then it tries to guess their name, in case it was not possible to find one the name will be No name (without brackets) and next time it would not search (and query overpass api) again.
| rv = Route(route_variant.id, fr, to, stops, rm, ref, name) | ||
| rv.add_shape(route_variant, query_result_set) | ||
| shape = self._generate_shape(route_variant, query_result_set) | ||
| rv = Route(route_variant.id, fr, to, stops, rm, ref, name, shape) |
There was a problem hiding this comment.
Nice the shape now gets supplied at construction time!
| for stop in self.stops.values(): | ||
|
|
||
| # If there is no name, query one intelligently from OSM | ||
| if stop.name == "[" + self.stop_no_name + "]": |
There was a problem hiding this comment.
I see this is how you identify the stops that haven't got a name. Maybe it is better use None here and only change all that are still none None after this method ran (or didn't ran) to the variable from the config file?
There was a problem hiding this comment.
Yes, I like the proposal of using None. It just left it as it was before, in order to keep pull requests small. Here is a new issue for this: #47
Related to issue #39.
FenixStopCreatorintoOsmHelpername_auto)name_without)add_shape()fromRouteto_generate_shape()inOsmHelperis_valid_stop_candidate()fromStopto_is_valid_stop_candidate()inOsmHelper