add multi-arch images using ko #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advantages: * no Dockerfile * multi-arch images can be built/pushed in one command. * reproducible builds as they are timestamped to 0. disadvantages: * limited to os/arch combonatios supported on the base image (gcr.io/distroless/static:nonroot) * binaries are compiled twice * produced binaries in GH releases vs container images are not identical (there's visible size diff, needs debugging) * can't use OCI labels such as `org.opencontainers.image.source` but they are not critical as GitHub still associates them to the repo correctly and they probably will be supported in ko at some point. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
|
cc:@sxd I will go with this patch instead and cut a release. |
tony-assembly
added a commit
to mx51/grpc-health-probe
that referenced
this pull request
Sep 8, 2022
* Fix rpc-timeout not being used correctly (grpc-ecosystem#91) * add multi-arch images using ko (grpc-ecosystem#90) * docs: adds documentation for RPC headers. (grpc-ecosystem#80) * docs: update -rpc-header examples Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com> * Release v0.4.6 * Add note on k8s 1.23 builtin grpc health probes Alternative take on grpc-ecosystem#99. * README.md: typo fix * Pick up security fixes with new Go version (grpc-ecosystem#105) * add support for ALTS transport (grpc-ecosystem#106) * Release v0.4.8 * Release v0.4.9 * Release v0.4.9 (bump dependencies) Fixes grpc-ecosystem#107. Fixes grpc-ecosystem#112. Fixes grpc-ecosystem#113. * Release v0.4.10 * Upgrade go to 1.18 to resolve security vulnerability CVE-2022-27191 (grpc-ecosystem#115) * Release v0.4.11 * Update dependencies * Bump Go version * Release v0.4.12 * updating code owners Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com> Co-authored-by: Neal Patel <neal@ineal.me> Co-authored-by: Ahmet Alp Balkan <ahmetb@google.com> Co-authored-by: José Carlos Chávez <jcchavezs@gmail.com> Co-authored-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com> Co-authored-by: Idan Kamara <i@idank.me> Co-authored-by: Ahmet Alp Balkan <ahmet@twitter.com> Co-authored-by: David B <dbrenecki@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative take to #86.
Fixes #85.
advantages:
disadvantages:
image (gcr.io/distroless/static:nonroot) and linux/386
is currently not published on distroless.
are not identical (there's visible size diff, needs debugging)
org.opencontainers.image.sourcebut they are not critical as GitHub still associates them
to the repo correctly and they probably will be supported in
ko at some point.
PTAL @sxd @jzelinskie @mnencia