This repository has been archived by the owner on May 30, 2024. It is now read-only.
[patch] Grpc ecosystem master #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Alternative take on grpc-ecosystem#99.
Fixes grpc-ecosystem#107. Fixes grpc-ecosystem#112. Fixes grpc-ecosystem#113.
…into grpc-ecosystem-master # Conflicts: # .github/workflows/ci.yml # .github/workflows/release.yml
|
After merging this PR, grpc-health-probe will be version |
awilmore
reviewed
Sep 8, 2022
Comment on lines
+12
to
+14
| > :warning: [**Kubernetes v1.23 has now introduced built-in gRPC health checking**][k8s-new] | ||
| > capability as an alpha feature. As a result, you might no longer need to use this tool and use the | ||
| > native Kubernetes feature instead. |
There was a problem hiding this comment.
@tony-assembly interesting... might be worth looking into (where's bmon when you need him?)
There was a problem hiding this comment.
i know 😢 how do you propose we give this a k8s feature a crack? I'd be happy to help
There was a problem hiding this comment.
looks like we might just be able to plug it in! https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-a-grpc-liveness-probe
There was a problem hiding this comment.
We can try it out in RND... I'll create a ticket
|
Merged and tagged as |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.